Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-07 Thread Paul Brook
> On Fri, Mar 05, 2010 at 11:15:45AM +, Paul Brook wrote: > > > TCG internal helpers only access to the values passed in arguments, and > > > do not modify the CPU internal state. Thus they can be declared as > > > const and pure. > > > > I think this needs an explanatory comment. It's not imme

Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-05 Thread Aurelien Jarno
On Fri, Mar 05, 2010 at 11:15:45AM +, Paul Brook wrote: > > TCG internal helpers only access to the values passed in arguments, and > > do not modify the CPU internal state. Thus they can be declared as > > const and pure. > > I think this needs an explanatory comment. It's not immediately obv

Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-05 Thread Paul Brook
> TCG internal helpers only access to the values passed in arguments, and > do not modify the CPU internal state. Thus they can be declared as > const and pure. I think this needs an explanatory comment. It's not immediately obvious that tcg_gen_helperN and tcg_gen_helper{32,64} have significantl

[Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-04 Thread Aurelien Jarno
TCG internal helpers only access to the values passed in arguments, and do not modify the CPU internal state. Thus they can be declared as const and pure. Signed-off-by: Aurelien Jarno --- tcg/tcg-op.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op.h b