Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread li guang
在 2012-12-06四的 09:48 +,Peter Maydell写道: > On 6 December 2012 09:36, Andreas Färber wrote: > > Am 06.12.2012 10:27, schrieb li guang: > >> 在 2012-12-06四的 09:23 +,Peter Maydell写道: > >>> On 6 December 2012 09:16, li guang wrote: > 在 2012-12-06四的 08:54 +,Peter Maydell写道: > > On 6

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread Andreas Färber
Am 06.12.2012 10:48, schrieb Peter Maydell: > On 6 December 2012 09:36, Andreas Färber wrote: >> The code comment specifically says "reset local breakpoints". IIUC you >> are also resetting global breakpoints, which you shouldn't. >> >> Personally I'd be fine with a hw_local_breakpoint_enabled().

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread Peter Maydell
On 6 December 2012 09:36, Andreas Färber wrote: > Am 06.12.2012 10:27, schrieb li guang: >> 在 2012-12-06四的 09:23 +,Peter Maydell写道: >>> On 6 December 2012 09:16, li guang wrote: 在 2012-12-06四的 08:54 +,Peter Maydell写道: > On 6 December 2012 03:03, liguang wrote: >> Signed-off-

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread Peter Maydell
On 6 December 2012 09:27, li guang wrote: > 在 2012-12-06四的 09:23 +,Peter Maydell写道: >> I mean that in the comments on the previous version of this >> patchseet we explained that this check is specifically checking >> for whether the breakpoint is enabled locally, and that your >> change to jus

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread Andreas Färber
Am 06.12.2012 10:27, schrieb li guang: > 在 2012-12-06四的 09:23 +,Peter Maydell写道: >> On 6 December 2012 09:16, li guang wrote: >>> 在 2012-12-06四的 08:54 +,Peter Maydell写道: On 6 December 2012 03:03, liguang wrote: > Signed-off-by: liguang > --- a/target-i386/seg_helper.c >

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread Wei-Ren Chen
On Thu, Dec 06, 2012 at 05:27:44PM +0800, li guang wrote: > 在 2012-12-06四的 09:23 +,Peter Maydell写道: > > On 6 December 2012 09:16, li guang wrote: > > > 在 2012-12-06四的 08:54 +,Peter Maydell写道: > > >> On 6 December 2012 03:03, liguang wrote: > > >> > Signed-off-by: liguang > > >> > --- a/t

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread Peter Maydell
On 6 December 2012 09:16, li guang wrote: > 在 2012-12-06四的 08:54 +,Peter Maydell写道: >> On 6 December 2012 03:03, liguang wrote: >> > Signed-off-by: liguang >> > --- a/target-i386/seg_helper.c >> > +++ b/target-i386/seg_helper.c >> > @@ -465,9 +465,9 @@ static void switch_tss(CPUX86State *env

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread li guang
在 2012-12-06四的 09:23 +,Peter Maydell写道: > On 6 December 2012 09:16, li guang wrote: > > 在 2012-12-06四的 08:54 +,Peter Maydell写道: > >> On 6 December 2012 03:03, liguang wrote: > >> > Signed-off-by: liguang > >> > --- a/target-i386/seg_helper.c > >> > +++ b/target-i386/seg_helper.c > >> > @

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread li guang
在 2012-12-06四的 08:54 +,Peter Maydell写道: > On 6 December 2012 03:03, liguang wrote: > > Signed-off-by: liguang > > --- a/target-i386/seg_helper.c > > +++ b/target-i386/seg_helper.c > > @@ -465,9 +465,9 @@ static void switch_tss(CPUX86State *env, int > > tss_selector, > > > > #ifndef CONFIG_U

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-06 Thread Peter Maydell
On 6 December 2012 03:03, liguang wrote: > Signed-off-by: liguang > --- a/target-i386/seg_helper.c > +++ b/target-i386/seg_helper.c > @@ -465,9 +465,9 @@ static void switch_tss(CPUX86State *env, int tss_selector, > > #ifndef CONFIG_USER_ONLY > /* reset local breakpoints */ > -if (env->d

[Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-05 Thread liguang
Signed-off-by: liguang --- target-i386/helper.c | 74 +--- target-i386/machine.c |5 ++- target-i386/misc_helper.c |4 +- target-i386/seg_helper.c |6 ++-- 4 files changed, 57 insertions(+), 32 deletions(-) diff --git a/target-i386/

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-05 Thread Jan Kiszka
On 2012-12-05 01:56, li guang wrote: >>> @@ -1014,22 +1016,40 @@ void hw_breakpoint_remove(CPUX86State *env, int >>> index) >>> int check_hw_breakpoints(CPUX86State *env, int force_dr6_update) >>> { >>> target_ulong dr6; >>> -int reg, type; >>> +int index; >>> int hit_enabled =

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-04 Thread li guang
在 2012-12-04二的 18:51 +,Blue Swirl写道: > On Tue, Dec 4, 2012 at 8:11 AM, liguang wrote: > > Signed-off-by: liguang > > --- > > target-i386/helper.c | 70 > > + > > target-i386/machine.c |2 +- > > target-i386/misc_helper.c |4 +- >

[Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-04 Thread liguang
Signed-off-by: liguang --- target-i386/helper.c | 70 + target-i386/machine.c |2 +- target-i386/misc_helper.c |4 +- target-i386/seg_helper.c |6 ++-- 4 files changed, 51 insertions(+), 31 deletions(-) diff --git a/target-i386/

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 8:11 AM, liguang wrote: > Signed-off-by: liguang > --- > target-i386/helper.c | 70 > + > target-i386/machine.c |2 +- > target-i386/misc_helper.c |4 +- > target-i386/seg_helper.c |6 ++-- > 4 files chan