Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media

2017-11-13 Thread Alberto Garcia
On Mon 13 Nov 2017 04:49:48 PM CET, Stefan Hajnoczi wrote: > On Fri, Nov 10, 2017 at 08:54:48PM +0200, Alberto Garcia wrote: >> +result = self.vm.qmp("blockdev-add", driver = "null-aio", >> + node_name = "cd0") > > PEP8 says: > > "Don't use spaces around the = s

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media

2017-11-13 Thread Stefan Hajnoczi
On Fri, Nov 10, 2017 at 08:54:48PM +0200, Alberto Garcia wrote: > +result = self.vm.qmp("blockdev-add", driver = "null-aio", > + node_name = "cd0") PEP8 says: "Don't use spaces around the = sign when used to indicate a keyword argument or a default parameter va

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media

2017-11-13 Thread Alberto Garcia
On Fri 10 Nov 2017 11:21:27 PM CET, Max Reitz wrote: > By the way, I just noticed that this test tests that > x-blockdev-remove-medium and x-blockdev-insert-medium do not destroy > throttling information -- which is exactly why those commands had been > declared experimental in the first place. O

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media

2017-11-10 Thread Max Reitz
On 2017-11-10 19:54, Alberto Garcia wrote: > This test hotplugs a CD drive to a VM and checks that I/O limits can > be set only when the drive has media inserted and that they are kept > when the media is replaced. > > This also tests the removal of a device with valid I/O limits set but > no medi

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media

2017-11-10 Thread Max Reitz
On 2017-11-10 19:54, Alberto Garcia wrote: > This test hotplugs a CD drive to a VM and checks that I/O limits can > be set only when the drive has media inserted and that they are kept > when the media is replaced. > > This also tests the removal of a device with valid I/O limits set but > no medi

[Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media

2017-11-10 Thread Alberto Garcia
This test hotplugs a CD drive to a VM and checks that I/O limits can be set only when the drive has media inserted and that they are kept when the media is replaced. This also tests the removal of a device with valid I/O limits set but no media inserted. This involves deleting and disabling the li