Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-31 Thread Amos Kong
On 31/05/12 19:00, Paolo Bonzini wrote: Il 30/05/2012 15:26, Luiz Capitulino ha scritto: qapi-types.h: typedef enum KeyCodes { KEY_CODES_SHIFT = 0, KEY_CODES_SHIFT_R = 1, KEY_CODES_ALT = 2, KEY_CODES_< = .. ^^^ problem should exist here That's because

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-31 Thread Paolo Bonzini
Il 30/05/2012 15:26, Luiz Capitulino ha scritto: >> > >> > qapi-types.h: >> > typedef enum KeyCodes >> > { >> > KEY_CODES_SHIFT = 0, >> > KEY_CODES_SHIFT_R = 1, >> > KEY_CODES_ALT = 2, >> > >> > KEY_CODES_< = .. >> > >> > ^^^ problem should exist here > That's b

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-30 Thread Luiz Capitulino
On Wed, 30 May 2012 18:17:54 +0800 Amos Kong wrote: > On 29/05/12 21:24, Luiz Capitulino wrote: > > On Tue, 29 May 2012 20:17:53 +0800 > > Amos Kong wrote: > > > >> On 05/29/2012 07:57 PM, Amos Kong wrote: > >>> On 05/25/2012 09:14 PM, Anthony Liguori wrote: > On 05/24/2012 10:51 PM, Eric B

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-30 Thread Amos Kong
- Original Message - > On Wed, 30 May 2012 18:17:54 +0800 > Amos Kong wrote: > > > On 29/05/12 21:24, Luiz Capitulino wrote: > > > On Tue, 29 May 2012 20:17:53 +0800 > > > Amos Kong wrote: > > > > > >> On 05/29/2012 07:57 PM, Amos Kong wrote: > > >>> On 05/25/2012 09:14 PM, Anthony Liguo

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-30 Thread Amos Kong
On 29/05/12 21:24, Luiz Capitulino wrote: On Tue, 29 May 2012 20:17:53 +0800 Amos Kong wrote: On 05/29/2012 07:57 PM, Amos Kong wrote: On 05/25/2012 09:14 PM, Anthony Liguori wrote: On 05/24/2012 10:51 PM, Eric Blake wrote: On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use.

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-29 Thread Luiz Capitulino
On Tue, 29 May 2012 20:17:53 +0800 Amos Kong wrote: > On 05/29/2012 07:57 PM, Amos Kong wrote: > > On 05/25/2012 09:14 PM, Anthony Liguori wrote: > >> On 05/24/2012 10:51 PM, Eric Blake wrote: > >>> On 05/24/2012 09:32 PM, Amos Kong wrote: > Convert 'sendkey' to use. do_sendkey() depends on

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-29 Thread Amos Kong
On 05/29/2012 07:57 PM, Amos Kong wrote: > On 05/25/2012 09:14 PM, Anthony Liguori wrote: >> On 05/24/2012 10:51 PM, Eric Blake wrote: >>> On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sendkey() to m

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-29 Thread Amos Kong
On 05/25/2012 09:14 PM, Anthony Liguori wrote: > On 05/24/2012 10:51 PM, Eric Blake wrote: >> On 05/24/2012 09:32 PM, Amos Kong wrote: >>> Convert 'sendkey' to use. do_sendkey() depends on some variables >>> in monitor.c, so reserve qmp_sendkey() to monitor.c Rename >>> 'string' to 'keys', rename

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 11:32:01 +0800 Amos Kong wrote: > Convert 'sendkey' to use. do_sendkey() depends on some variables > in monitor.c, so reserve qmp_sendkey() to monitor.c > Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' Splitting the args rename to a different patch would make re

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Jeff Cody
On 05/25/2012 09:00 AM, Luiz Capitulino wrote: > On Fri, 25 May 2012 14:20:33 +0800 > Amos Kong wrote: > >> On 25/05/12 11:51, Eric Blake wrote: >>> On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sen

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Anthony Liguori
On 05/25/2012 08:06 AM, Luiz Capitulino wrote: On Fri, 25 May 2012 08:34:54 +0100 "Daniel P. Berrange" wrote: On Fri, May 25, 2012 at 02:20:33PM +0800, Amos Kong wrote: On 25/05/12 11:51, Eric Blake wrote: On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depen

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 14:12:39 +0100 "Daniel P. Berrange" wrote: > On Fri, May 25, 2012 at 10:06:11AM -0300, Luiz Capitulino wrote: > > On Fri, 25 May 2012 08:34:54 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Fri, May 25, 2012 at 02:20:33PM +0800, Amos Kong wrote: > > > > On 25/05/12 11:51

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Anthony Liguori
On 05/24/2012 10:51 PM, Eric Blake wrote: On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sendkey() to monitor.c Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' Signed-off-by: Amos Kong +## +#

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Daniel P. Berrange
On Fri, May 25, 2012 at 10:06:11AM -0300, Luiz Capitulino wrote: > On Fri, 25 May 2012 08:34:54 +0100 > "Daniel P. Berrange" wrote: > > > On Fri, May 25, 2012 at 02:20:33PM +0800, Amos Kong wrote: > > > On 25/05/12 11:51, Eric Blake wrote: > > > >On 05/24/2012 09:32 PM, Amos Kong wrote: > > > >>C

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 08:34:54 +0100 "Daniel P. Berrange" wrote: > On Fri, May 25, 2012 at 02:20:33PM +0800, Amos Kong wrote: > > On 25/05/12 11:51, Eric Blake wrote: > > >On 05/24/2012 09:32 PM, Amos Kong wrote: > > >>Convert 'sendkey' to use. do_sendkey() depends on some variables > > >>in monito

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 14:20:33 +0800 Amos Kong wrote: > On 25/05/12 11:51, Eric Blake wrote: > > On 05/24/2012 09:32 PM, Amos Kong wrote: > >> Convert 'sendkey' to use. do_sendkey() depends on some variables > >> in monitor.c, so reserve qmp_sendkey() to monitor.c > >> Rename 'string' to 'keys', re

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, May 25, 2012 at 02:20:33PM +0800, Amos Kong wrote: >> On 25/05/12 11:51, Eric Blake wrote: >> >On 05/24/2012 09:32 PM, Amos Kong wrote: >> >>Convert 'sendkey' to use. do_sendkey() depends on some variables >> >>in monitor.c, so reserve qmp_sendkey() to monit

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-25 Thread Daniel P. Berrange
On Fri, May 25, 2012 at 02:20:33PM +0800, Amos Kong wrote: > On 25/05/12 11:51, Eric Blake wrote: > >On 05/24/2012 09:32 PM, Amos Kong wrote: > >>Convert 'sendkey' to use. do_sendkey() depends on some variables > >>in monitor.c, so reserve qmp_sendkey() to monitor.c > >>Rename 'string' to 'keys', r

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-24 Thread Amos Kong
On 25/05/12 11:51, Eric Blake wrote: On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sendkey() to monitor.c Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' Signed-off-by: Amos Kong +## +# @sen

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-24 Thread Eric Blake
On 05/24/2012 09:32 PM, Amos Kong wrote: > Convert 'sendkey' to use. do_sendkey() depends on some variables > in monitor.c, so reserve qmp_sendkey() to monitor.c > Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' > > Signed-off-by: Amos Kong > +## > +# @sendkey: > +# > +# Send keys t

[Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-24 Thread Amos Kong
Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sendkey() to monitor.c Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' Signed-off-by: Amos Kong --- hmp-commands.hx |4 ++-- hmp.c| 11 +++ hmp.h|