On Thu, Apr 5, 2012 at 12:24, Andreas Färber wrote:
> Am 04.04.2012 22:54, schrieb Peter Maydell:
>> On 4 April 2012 21:34, Blue Swirl wrote:
>>> On Wed, Apr 4, 2012 at 20:11, Peter Maydell
>>> wrote:
I'd much rather enable a #define to turn on debugging than faff about
with tracing.
Am 04.04.2012 22:54, schrieb Peter Maydell:
> On 4 April 2012 21:34, Blue Swirl wrote:
>> On Wed, Apr 4, 2012 at 20:11, Peter Maydell wrote:
>>> I'd much rather enable a #define to turn on debugging than faff about
>>> with tracing. It's simple and straightforward, you can do it with a
>>> single
On 4 April 2012 21:34, Blue Swirl wrote:
> On Wed, Apr 4, 2012 at 20:11, Peter Maydell wrote:
>> I'd much rather enable a #define to turn on debugging than faff about
>> with tracing. It's simple and straightforward, you can do it with a
>> single obvious change and recompile, and nobody has to l
On Wed, Apr 4, 2012 at 20:11, Peter Maydell wrote:
> On 4 April 2012 20:18, Blue Swirl wrote:
>> On Mon, Apr 2, 2012 at 04:17, David Gibson
>> wrote:
>>> From: Alexey Kardashevskiy
>>> This adds DPRINTF() macros with the usual conventions to the spapr_pci
>>> code.
>>
>> Please use tracepoints
On 4 April 2012 20:18, Blue Swirl wrote:
> On Mon, Apr 2, 2012 at 04:17, David Gibson
> wrote:
>> From: Alexey Kardashevskiy
>> This adds DPRINTF() macros with the usual conventions to the spapr_pci
>> code.
>
> Please use tracepoints instead of printf statements. Tracing is more
> flexible, mo
On Mon, Apr 2, 2012 at 04:17, David Gibson wrote:
> From: Alexey Kardashevskiy
>
> This adds DPRINTF() macros with the usual conventions to the spapr_pci
> code.
Please use tracepoints instead of printf statements. Tracing is more
flexible, more efficient and does not suffer from bitrot.
> Cc:
From: Alexey Kardashevskiy
This adds DPRINTF() macros with the usual conventions to the spapr_pci
code.
Cc: Michael S. Tsirkin
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: David Gibson
---
hw/spapr_pci.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/h