irkin;
> Huangpeng (Peter); Igor Mammedov; Paolo Bonzini; Andreas Färber
> Subject: Re: [Qemu-devel] [PATCH 3/3] pcie: using error_setg instead of
> impolite assert
>
> Add "hotplug" to the subject line somewhere.
>
OK.
>
> On Tue, Aug 19, 2014 at 7:41 PM, wrote:
> > ---
> > hw/pci/pcie.c | 6 +-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> > index a123c01..7b46140 100644
> > --- a/hw/pci/pcie.c
> > +++ b/hw/pci/pcie.c
> > @@ -254,7 +254,11 @@ void pcie_cap_slot_hotplug_cb(HotplugHandler
> *hot
On Tue, Aug 19, 2014 at 05:41:45PM +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> It's enough of reporting an error. Assert() is not acceptable
> because the error is not a fatal error.
>
> Signed-off-by: Gonglei
> ---
> hw/pci/pcie.c | 6 +-
> 1 file changed, 5 insertions(+), 1
Add "hotplug" to the subject line somewhere.
On Tue, Aug 19, 2014 at 7:41 PM, wrote:
> From: Gonglei
>
> It's enough of reporting an error. Assert() is not acceptable
"It's enough to report an error".
Regards,
Peter
> because the error is not a fatal error.
>
> Signed-off-by: Gonglei
> ---
From: Gonglei
It's enough of reporting an error. Assert() is not acceptable
because the error is not a fatal error.
Signed-off-by: Gonglei
---
hw/pci/pcie.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index a123c01..7b46140 100644
---
