Re: [Qemu-devel] [PATCH 3/3] log: Fix qemu_set_log_filename() error handling

2016-06-15 Thread Eric Blake
On 06/15/2016 11:27 AM, Markus Armbruster wrote: > When qemu_set_log_filename() detects an invalid file name, it reports > an error, closes the log file (if any), and starts logging to stderr > (unless daemonized or nothing is being logged). > > This is wrong. Asking for an invalid log file on th

[Qemu-devel] [PATCH 3/3] log: Fix qemu_set_log_filename() error handling

2016-06-15 Thread Markus Armbruster
When qemu_set_log_filename() detects an invalid file name, it reports an error, closes the log file (if any), and starts logging to stderr (unless daemonized or nothing is being logged). This is wrong. Asking for an invalid log file on the command line should be fatal. Asking for one in the moni