Re: [Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-28 Thread Roman Penyaev
On Wed, Sep 28, 2016 at 11:34 AM, Fam Zheng wrote: > On Wed, 09/28 11:14, Roman Penyaev wrote: >> On Wed, Sep 28, 2016 at 5:01 AM, Fam Zheng wrote: >> > On Tue, 09/27 19:55, Roman Penyaev wrote: >> >> > The bug is 100% deterministic. Just boot up a guest with -drive >> >> > format=qcow2,aio=nati

Re: [Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-28 Thread Fam Zheng
On Wed, 09/28 11:14, Roman Penyaev wrote: > On Wed, Sep 28, 2016 at 5:01 AM, Fam Zheng wrote: > > On Tue, 09/27 19:55, Roman Penyaev wrote: > >> > The bug is 100% deterministic. Just boot up a guest with -drive > >> > format=qcow2,aio=native. > >> > >> It turns out to be that everything is broken

Re: [Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-28 Thread Roman Penyaev
On Wed, Sep 28, 2016 at 5:01 AM, Fam Zheng wrote: > On Tue, 09/27 19:55, Roman Penyaev wrote: >> > The bug is 100% deterministic. Just boot up a guest with -drive >> > format=qcow2,aio=native. >> >> It turns out to be that everything is broken. I started all my >> tests with format=raw,aio=nativ

Re: [Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-27 Thread Fam Zheng
On Tue, 09/27 19:55, Roman Penyaev wrote: > > The bug is 100% deterministic. Just boot up a guest with -drive > > format=qcow2,aio=native. > > It turns out to be that everything is broken. I started all my > tests with format=raw,aio=native and immediately got coroutine > recursive. That is com

Re: [Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-27 Thread Roman Penyaev
On Tue, Sep 27, 2016 at 5:25 PM, Stefan Hajnoczi wrote: > On Tue, Sep 27, 2016 at 04:29:55PM +0200, Roman Penyaev wrote: >> On Tue, Sep 27, 2016 at 4:06 PM, Stefan Hajnoczi wrote: >> > Commit 0ed93d84edabc7656f5c998ae1a346fe8b94ca54 ("linux-aio: process >> > completions from ioq_submit()") added

Re: [Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-27 Thread Stefan Hajnoczi
On Tue, Sep 27, 2016 at 04:29:55PM +0200, Roman Penyaev wrote: > On Tue, Sep 27, 2016 at 4:06 PM, Stefan Hajnoczi wrote: > > Commit 0ed93d84edabc7656f5c998ae1a346fe8b94ca54 ("linux-aio: process > > completions from ioq_submit()") added an optimization that processes > > completions each time ioq_s

Re: [Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-27 Thread Roman Penyaev
Hey Stefan, On Tue, Sep 27, 2016 at 4:06 PM, Stefan Hajnoczi wrote: > Commit 0ed93d84edabc7656f5c998ae1a346fe8b94ca54 ("linux-aio: process > completions from ioq_submit()") added an optimization that processes > completions each time ioq_submit() returns with requests in flight. > This commit int

[Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-27 Thread Stefan Hajnoczi
Commit 0ed93d84edabc7656f5c998ae1a346fe8b94ca54 ("linux-aio: process completions from ioq_submit()") added an optimization that processes completions each time ioq_submit() returns with requests in flight. This commit introduces a "Co-routine re-entered recursively" error which can be triggered wit