Re: [Qemu-devel] [PATCH 3/3] ide: add TRIM support

2011-06-10 Thread Kevin Wolf
Am 19.05.2011 10:58, schrieb Christoph Hellwig: > Add support for TRIM sub function of the data set management command, > and wire it up to the qemu discard infrastructure. > > Signed-off-by: Christoph Hellwig > Index: qemu/hw/ide/pci.c > =

Re: [Qemu-devel] [PATCH 3/3] ide: add TRIM support

2011-06-10 Thread Kevin Wolf
Am 19.05.2011 10:58, schrieb Christoph Hellwig: > Add support for TRIM sub function of the data set management command, > and wire it up to the qemu discard infrastructure. > > Signed-off-by: Christoph Hellwig > > Index: qemu/hw/ide/core.c > ==

[Qemu-devel] [PATCH 3/3] ide: add TRIM support

2011-05-19 Thread Christoph Hellwig
Add support for TRIM sub function of the data set management command, and wire it up to the qemu discard infrastructure. Signed-off-by: Christoph Hellwig Index: qemu/hw/ide/core.c === --- qemu.orig/hw/ide/core.c 2011-05-18 20:30

Re: [Qemu-devel] [PATCH 3/3] ide: add TRIM support

2011-05-04 Thread Kevin Wolf
Am 03.05.2011 14:06, schrieb Christoph Hellwig: > Add support for TRIM sub function of the data set management command, > and wire it up to the qemu discard infrastructure. > > Signed-off-by: Christoph Hellwig Don't failed trim requests turn into writes now? Also, there are some braces missing.

Re: [Qemu-devel] [PATCH 3/3] ide: add TRIM support

2011-05-03 Thread Christoph Hellwig
On Tue, May 03, 2011 at 03:08:43PM +0200, Paolo Bonzini wrote: > On 05/03/2011 02:06 PM, Christoph Hellwig wrote: >> +case IDE_DMA_TRIM: >> +m->aiocb = dma_bdrv_io(s->bs,&s->sg, sector_num, >> + ide_issue_trim,, pmac_ide_transfer_cb, s, 1); >> +brea

Re: [Qemu-devel] [PATCH 3/3] ide: add TRIM support

2011-05-03 Thread Paolo Bonzini
On 05/03/2011 02:06 PM, Christoph Hellwig wrote: +case IDE_DMA_TRIM: +m->aiocb = dma_bdrv_io(s->bs,&s->sg, sector_num, + ide_issue_trim,, pmac_ide_transfer_cb, s, 1); +break; Not compile-tested? Paolo

[Qemu-devel] [PATCH 3/3] ide: add TRIM support

2011-05-03 Thread Christoph Hellwig
Add support for TRIM sub function of the data set management command, and wire it up to the qemu discard infrastructure. Signed-off-by: Christoph Hellwig Index: qemu/hw/ide/core.c === --- qemu.orig/hw/ide/core.c 2011-05-03 11:35