Re: [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev

2011-07-07 Thread Peter Maydell
On 7 July 2011 16:29, andrzej zaborowski wrote: > Optimally > we should pass the clock as a pointer or name, not only the baudrate > (clocks can be stopped, reparented, or have frequency changed > dynamically -- in fact the OS will most likely manipulate the uart > source clock frequency during in

Re: [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev

2011-07-07 Thread andrzej zaborowski
Hi, On 5 July 2011 15:19, Peter Maydell wrote: > On 4 July 2011 23:39, andrzej zaborowski wrote: >> I'd also prefer that omap2_gpio_init remains a function that >> does all the qdev magic in omap_gpio.c and with the current signature > > I'm not convinced about this. Implementing the GPIO module

Re: [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev

2011-07-05 Thread Peter Maydell
On 4 July 2011 23:39, andrzej zaborowski wrote: > Patch looks good overall, but for consistency we should rename > functions which start with omap2_gpio_module_ to omap2_gpio_ if the > state pointer passed is no longer the module pointer but instead the > whole thing pointer.  But maybe it would m

Re: [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev

2011-07-04 Thread andrzej zaborowski
Hi, On 29 June 2011 20:53, Peter Maydell wrote: > From: Juha Riihimäki > > Convert the OMAP GPIO module to qdev. > > Signed-off-by: Juha Riihimäki > [Riku Voipio: Fixes and restructuring patchset] > Signed-off-by: Riku Voipio > [Peter Maydell: More fixes and cleanups for upstream submission] >

[Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev

2011-06-29 Thread Peter Maydell
From: Juha Riihimäki Convert the OMAP GPIO module to qdev. Signed-off-by: Juha Riihimäki [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio [Peter Maydell: More fixes and cleanups for upstream submission] Signed-off-by: Peter Maydell --- hw/nseries.c | 47 +--