Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning

2015-11-10 Thread Steven Noonan
On Tue, Nov 10, 2015 at 12:06 PM, Markus Armbruster wrote: > Steven Noonan writes: > >> On Tue, Nov 10, 2015 at 10:52 AM, Markus Armbruster >> wrote: >>> Peter Maydell writes: >>> On 10 November 2015 at 17:33, Paolo Bonzini wrote: > > > On 10/11/2015 16:57, Stefan Hajnoczi wr

Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 20:51, Steven Noonan wrote: > I don't read this warning as "clang will do crazy things with your > code eventually". Clang has always been very verbose when it comes to > undefined behavior, and I don't think that's really a bad thing to do. Sure, but it doesn't belong in -Wall. I

Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning

2015-11-10 Thread Markus Armbruster
Steven Noonan writes: > On Tue, Nov 10, 2015 at 10:52 AM, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 10 November 2015 at 17:33, Paolo Bonzini wrote: On 10/11/2015 16:57, Stefan Hajnoczi wrote: > clang 3.7.0 on x86_64 warns about the following: > >

Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning

2015-11-10 Thread Steven Noonan
On Tue, Nov 10, 2015 at 10:52 AM, Markus Armbruster wrote: > Peter Maydell writes: > >> On 10 November 2015 at 17:33, Paolo Bonzini wrote: >>> >>> >>> On 10/11/2015 16:57, Stefan Hajnoczi wrote: clang 3.7.0 on x86_64 warns about the following: disas/arm.c:1782:17: warning: shift

Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning

2015-11-10 Thread Markus Armbruster
Peter Maydell writes: > On 10 November 2015 at 17:33, Paolo Bonzini wrote: >> >> >> On 10/11/2015 16:57, Stefan Hajnoczi wrote: >>> clang 3.7.0 on x86_64 warns about the following: >>> >>> disas/arm.c:1782:17: warning: shifting a negative signed value is >>> undefined [-Wshift-negative-value]

Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 18:48, Peter Maydell wrote: > It could be they're attempting to warn us now about the possibility > that in a future version of clang they will start using this UB > to optimize with. Good luck to them. Paolo

Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning

2015-11-10 Thread Peter Maydell
On 10 November 2015 at 17:33, Paolo Bonzini wrote: > > > On 10/11/2015 16:57, Stefan Hajnoczi wrote: >> clang 3.7.0 on x86_64 warns about the following: >> >> disas/arm.c:1782:17: warning: shifting a negative signed value is >> undefined [-Wshift-negative-value] >> imm |= (-1 << 7); >>

Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 16:57, Stefan Hajnoczi wrote: > clang 3.7.0 on x86_64 warns about the following: > > disas/arm.c:1782:17: warning: shifting a negative signed value is undefined > [-Wshift-negative-value] > imm |= (-1 << 7); > ~~ ^ > > Note that this patch preserves the tab inde

[Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning

2015-11-10 Thread Stefan Hajnoczi
clang 3.7.0 on x86_64 warns about the following: disas/arm.c:1782:17: warning: shifting a negative signed value is undefined [-Wshift-negative-value] imm |= (-1 << 7); ~~ ^ Note that this patch preserves the tab indent in this source file because the surrounding code still uses