Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-03 Thread Wenchao Xia
于 2013-4-3 17:03, Kevin Wolf 写道: Am 03.04.2013 um 07:35 hat Wenchao Xia geschrieben: 于 2013-4-2 21:59, Kevin Wolf 写道: Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: Last operaton should be cancelled first. Signed-off-by: Wenchao Xia Should it? This commit message does little to con

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-03 Thread Kevin Wolf
Am 03.04.2013 um 07:35 hat Wenchao Xia geschrieben: > 于 2013-4-2 21:59, Kevin Wolf 写道: > >Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: > >> Last operaton should be cancelled first. > >> > >>Signed-off-by: Wenchao Xia > > > >Should it? This commit message does little to convince me. > > >

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-02 Thread Wenchao Xia
于 2013-4-2 21:59, Kevin Wolf 写道: Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: Last operaton should be cancelled first. Signed-off-by: Wenchao Xia Should it? This commit message does little to convince me. Kevin I think so, if two request are "snapshot_blkdev ide0 newimage.qcow

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-02 Thread Kevin Wolf
Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: > Last operaton should be cancelled first. > > Signed-off-by: Wenchao Xia Should it? This commit message does little to convince me. Kevin

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-01 Thread Wenchao Xia
于 2013-4-1 23:52, Eric Blake 写道: On 04/01/2013 04:01 AM, Wenchao Xia wrote: Last operaton should be cancelled first. s/operaton/operation/ [I don't care enough about US vs. UK to say whether canceled or cancelled looks better] Signed-off-by: Wenchao Xia --- blockdev.c |2 +- 1 f

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-01 Thread Eric Blake
On 04/01/2013 04:01 AM, Wenchao Xia wrote: > Last operaton should be cancelled first. s/operaton/operation/ [I don't care enough about US vs. UK to say whether canceled or cancelled looks better] > > Signed-off-by: Wenchao Xia > --- > blockdev.c |2 +- > 1 files changed, 1 insertions(+)

[Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-01 Thread Wenchao Xia
Last operaton should be cancelled first. Signed-off-by: Wenchao Xia --- blockdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 75416fb..a24d10e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -954,7 +954,7 @@ void qmp_transaction(Blockdev