Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values

Am 08.02.2014 um 00:24 hat Laszlo Ersek geschrieben: > On 02/07/14 22:45, Kevin Wolf wrote: > > Am 07.02.2014 um 17:27 hat Eric Blake geschrieben: > >> On 02/07/2014 09:12 AM, Kevin Wolf wrote: > >>> The behaviour of the ROUND_UP macro with negative numbers isn't obvious. > >>> It happens to do the

Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values

On 02/07/14 22:45, Kevin Wolf wrote: > Am 07.02.2014 um 17:27 hat Eric Blake geschrieben: >> On 02/07/2014 09:12 AM, Kevin Wolf wrote: >>> The behaviour of the ROUND_UP macro with negative numbers isn't obvious. >>> It happens to do the right thing in this please, but better avoid it. >> >> s/pleas

Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values

Am 07.02.2014 um 17:27 hat Eric Blake geschrieben: > On 02/07/2014 09:12 AM, Kevin Wolf wrote: > > The behaviour of the ROUND_UP macro with negative numbers isn't obvious. > > It happens to do the right thing in this please, but better avoid it. > > s/please/place/ Indeed... Thanks, fixed it loca

Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values

On 02/07/2014 09:12 AM, Kevin Wolf wrote: > The behaviour of the ROUND_UP macro with negative numbers isn't obvious. > It happens to do the right thing in this please, but better avoid it. s/please/place/ > > Suggested-by: Laszlo Ersek > Signed-off-by: Kevin Wolf > --- > block.c | 4 ++-- > 1

[Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values

The behaviour of the ROUND_UP macro with negative numbers isn't obvious. It happens to do the right thing in this please, but better avoid it. Suggested-by: Laszlo Ersek Signed-off-by: Kevin Wolf --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block