Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-30 Thread Vladimir Sementsov-Ogievskiy
30.05.2019 17:20, John Snow wrote: > > On 5/30/19 4:23 AM, Vladimir Sementsov-Ogievskiy wrote: >> 29.05.2019 21:08, John Snow wrote: >>> On 5/29/19 5:10 AM, Vladimir Sementsov-Ogievskiy wrote: 29.05.2019 2:24, John Snow wrote: > On 5/23/19 11:47 AM, Vladimir Sementsov-Ogievskiy wrote: >

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-30 Thread John Snow
On 5/30/19 4:23 AM, Vladimir Sementsov-Ogievskiy wrote: > 29.05.2019 21:08, John Snow wrote: >> On 5/29/19 5:10 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 29.05.2019 2:24, John Snow wrote: On 5/23/19 11:47 AM, Vladimir Sementsov-Ogievskiy wrote: [...] >> >> Right, we've not really used re

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-30 Thread Vladimir Sementsov-Ogievskiy
30.05.2019 11:23, Vladimir Sementsov-Ogievskiy wrote: > 29.05.2019 21:08, John Snow wrote: >> Max has picked this thread up for block discussion, so I'm going to >> stick to slightly more bitmap related discussion here; we'll resume >> block discussion in the other tail of this thread. >> [..] >

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-30 Thread Vladimir Sementsov-Ogievskiy
29.05.2019 21:08, John Snow wrote: > Max has picked this thread up for block discussion, so I'm going to > stick to slightly more bitmap related discussion here; we'll resume > block discussion in the other tail of this thread. > > On 5/29/19 5:10 AM, Vladimir Sementsov-Ogievskiy wrote: >> 29.05.2

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-29 Thread Max Reitz
On 29.05.19 17:58, Vladimir Sementsov-Ogievskiy wrote: > 29.05.2019 18:33, Max Reitz wrote: >> On 23.05.19 17:47, Vladimir Sementsov-Ogievskiy wrote: >>> Current logic >>> = >>> >>> Reopen rw -> ro: >>> >>> Store bitmaps and release BdrvDirtyBitmap's. >>> >>> Reopen ro -> rw: >>> >>> Lo

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-29 Thread John Snow
Max has picked this thread up for block discussion, so I'm going to stick to slightly more bitmap related discussion here; we'll resume block discussion in the other tail of this thread. On 5/29/19 5:10 AM, Vladimir Sementsov-Ogievskiy wrote: > 29.05.2019 2:24, John Snow wrote: >> >> >> On 5/23/19

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-29 Thread Vladimir Sementsov-Ogievskiy
29.05.2019 18:33, Max Reitz wrote: > On 23.05.19 17:47, Vladimir Sementsov-Ogievskiy wrote: >> Current logic >> = >> >> Reopen rw -> ro: >> >> Store bitmaps and release BdrvDirtyBitmap's. >> >> Reopen ro -> rw: >> >> Load bitmap list >> Skip bitmaps which for which we don't have BdrvDir

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-29 Thread Max Reitz
On 23.05.19 17:47, Vladimir Sementsov-Ogievskiy wrote: > Current logic > = > > Reopen rw -> ro: > > Store bitmaps and release BdrvDirtyBitmap's. > > Reopen ro -> rw: > > Load bitmap list > Skip bitmaps which for which we don't have BdrvDirtyBitmap [this is >the worst thing] > A

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-29 Thread Vladimir Sementsov-Ogievskiy
29.05.2019 2:24, John Snow wrote: > > > On 5/23/19 11:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> Current logic >> = >> >> Reopen rw -> ro: >> >> Store bitmaps and release BdrvDirtyBitmap's. >> >> Reopen ro -> rw: >> >> Load bitmap list >> Skip bitmaps which for which we don't have

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-28 Thread John Snow
On 5/23/19 11:47 AM, Vladimir Sementsov-Ogievskiy wrote: > Current logic > = > > Reopen rw -> ro: > > Store bitmaps and release BdrvDirtyBitmap's. > > Reopen ro -> rw: > > Load bitmap list > Skip bitmaps which for which we don't have BdrvDirtyBitmap [this is >the worst thing]

[Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

2019-05-23 Thread Vladimir Sementsov-Ogievskiy
Current logic = Reopen rw -> ro: Store bitmaps and release BdrvDirtyBitmap's. Reopen ro -> rw: Load bitmap list Skip bitmaps which for which we don't have BdrvDirtyBitmap [this is the worst thing] A kind of fail with error message if we see not readonly bitmap This leads to at l