On 26 September 2013 23:50, Fabien Chouteau wrote:
> On 09/26/2013 02:05 AM, Peter Maydell wrote:
>> On 26 September 2013 01:29, Fabien Chouteau wrote:
>>> I think that's what I did. I think the problem was to include
>>> 'monitor.h' in 'target-*/cpu.c'.
>>
>> Why doesn't that work?
>
> The probl
On 09/26/2013 02:05 AM, Peter Maydell wrote:
> On 26 September 2013 01:29, Fabien Chouteau wrote:
>> On 09/25/2013 05:51 PM, Peter Maydell wrote:
>>> On 26 September 2013 00:38, Fabien Chouteau wrote:
>>> It doesn't matter very much, but monitor.h seems the obvious
>>> place. You probably don't w
On 26 September 2013 01:29, Fabien Chouteau wrote:
> On 09/25/2013 05:51 PM, Peter Maydell wrote:
>> On 26 September 2013 00:38, Fabien Chouteau wrote:
>> It doesn't matter very much, but monitor.h seems the obvious
>> place. You probably don't want qom/cpu.h to have to drag in
>> monitor.h so a
On 09/25/2013 05:51 PM, Peter Maydell wrote:
> On 26 September 2013 00:38, Fabien Chouteau wrote:
>> On 09/25/2013 01:53 AM, Peter Maydell wrote:
>>>
>>> No, I really don't want to see another target #ifdef ladder, please.
>>> Put a 'static const MonitorDef *monitor_defs;' into CPUClass,
>>> and i
On 26 September 2013 00:38, Fabien Chouteau wrote:
> On 09/25/2013 01:53 AM, Peter Maydell wrote:
>>
>> No, I really don't want to see another target #ifdef ladder, please.
>> Put a 'static const MonitorDef *monitor_defs;' into CPUClass,
>> and initialize it in each target's class init function, p
On 09/25/2013 01:53 AM, Peter Maydell wrote:
>
> No, I really don't want to see another target #ifdef ladder, please.
> Put a 'static const MonitorDef *monitor_defs;' into CPUClass,
> and initialize it in each target's class init function, please.
> (You'll need to move the appropriate sections of
On 25 September 2013 01:46, Fabien Chouteau wrote:
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3351,6 +3351,23 @@ static const MonitorDef monitor_defs[] = {
> { "cleanwin", offsetof(CPUSPARCState, cleanwin) },
> { "fprs", offsetof(CPUSPARCState, fprs) },
> #endif
> +#elif defined(TARGET_A
Signed-off-by: Fabien Chouteau
---
monitor.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/monitor.c b/monitor.c
index 74f3f1b..e40c20d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3351,6 +3351,23 @@ static const MonitorDef monitor_defs[] = {
{ "cleanwin", offsetof(
