Re: [Qemu-devel] [PATCH 3/3] 9pfs-proxy: remove one half of redundrand code

2015-03-07 Thread Eric Blake
On 03/06/2015 02:43 PM, Michael Tokarev wrote: > The 9pfs-proxy code is actually terrible: it does the same > things again and again, ignoring function arguments and > re-inventing the same values again, and a lot of code must > be consistent with each other. s/redundrand/redundant/ in the subject

Re: [Qemu-devel] [PATCH 3/3] 9pfs-proxy: remove one half of redundrand code

2015-03-06 Thread Michael Tokarev
07.03.2015 00:43, Michael Tokarev пишет: > +retval = v9fs_marshal(&proxy->out_iovec, 1, PROXY_HDR_SZ, 0, fmt, ap); This should be the new v9fs_vmarshal() ofcourse. /mjt

[Qemu-devel] [PATCH 3/3] 9pfs-proxy: remove one half of redundrand code

2015-03-06 Thread Michael Tokarev
The 9pfs-proxy code is actually terrible: it does the same things again and again, ignoring function arguments and re-inventing the same values again, and a lot of code must be consistent with each other. In particular, lots of filesystem methods use common v9fs_request() function and pass all met