Re: [Qemu-devel] [PATCH 29/35] scsi-disk: remove cluster_size

2011-10-24 Thread Paolo Bonzini
On 10/24/2011 05:10 PM, Kevin Wolf wrote: > -bdrv_get_geometry(s->qdev.conf.bs,&nb_sectors); > -nb_sectors /= s->cluster_size; > -if (nb_sectors) { > -nb_sectors--; > +if (s->qdev.blocksize) { When would it be 0? And wouldn't we crash with a zero blocksize anyway?

Re: [Qemu-devel] [PATCH 29/35] scsi-disk: remove cluster_size

2011-10-24 Thread Kevin Wolf
Am 13.10.2011 13:03, schrieb Paolo Bonzini: > This field is redundant, and its presence makes it more complicated > to share reqops between the upcoming scsi-block and scsi-generic. > > Signed-off-by: Paolo Bonzini > --- > hw/scsi-disk.c | 45 ++--- > 1

[Qemu-devel] [PATCH 29/35] scsi-disk: remove cluster_size

2011-10-13 Thread Paolo Bonzini
This field is redundant, and its presence makes it more complicated to share reqops between the upcoming scsi-block and scsi-generic. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 45 ++--- 1 files changed, 22 insertions(+), 23 deletions(-) diff --g