Re: [Qemu-devel] [PATCH 28/55] block: Leave enforcing tray lock to device models

2011-07-21 Thread Luiz Capitulino
On Thu, 21 Jul 2011 17:16:13 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 20 Jul 2011 18:24:02 +0200 > > Markus Armbruster wrote: > > > >> The device model knows best when to accept the guest's eject command. > >> No need to detour through the block layer. > >> > >>

Re: [Qemu-devel] [PATCH 28/55] block: Leave enforcing tray lock to device models

2011-07-21 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 20 Jul 2011 18:24:02 +0200 > Markus Armbruster wrote: > >> The device model knows best when to accept the guest's eject command. >> No need to detour through the block layer. >> >> bdrv_eject() can't fail anymore. Make it void. > > But we're supposed to return

[Qemu-devel] [PATCH 28/55] block: Leave enforcing tray lock to device models

2011-07-20 Thread Markus Armbruster
The device model knows best when to accept the guest's eject command. No need to detour through the block layer. bdrv_eject() can't fail anymore. Make it void. Signed-off-by: Markus Armbruster --- block.c|7 +-- block.h|2 +- hw/ide/atapi.c | 29 +-