Re: [Qemu-devel] [PATCH 28/34] block: Introduce bs->explicit_options

2015-10-29 Thread Kevin Wolf
Am 15.05.2015 um 19:47 hat Max Reitz geschrieben: > 3) In bdrv_open(): > The QDict is just the one given to bdrv_open(). > > 3a) bdrv_open() call from bdrv_append_temp_snapshot(): > "file.driver" and "file.filename" are set, and these are the only > options in the whole QDict. Well... I'd argue th

Re: [Qemu-devel] [PATCH 28/34] block: Introduce bs->explicit_options

2015-05-15 Thread Max Reitz
On 08.05.2015 19:22, Kevin Wolf wrote: bs->options doesn't only contain options that the user explicitly requested, but also option that were derived from flags, the filename or inherited from the parent node. For reopen, it is important to know the difference because reopening the parent can ch

[Qemu-devel] [PATCH 28/34] block: Introduce bs->explicit_options

2015-05-08 Thread Kevin Wolf
bs->options doesn't only contain options that the user explicitly requested, but also option that were derived from flags, the filename or inherited from the parent node. For reopen, it is important to know the difference because reopening the parent can change inherited values in child nodes, but