Eric Blake writes:
> On 10/8/18 12:31 PM, Markus Armbruster wrote:
>> Calling error_report() from within a a function that takes an Error **
>
> s/a a/a/
Fixing, thanks!
>> argument is suspicious. qemu_fsdev_add() does that, and its caller
>> fsdev_init_func() then fails without setting an err
On Mon, 8 Oct 2018 19:31:22 +0200
Markus Armbruster wrote:
> Calling error_report() from within a a function that takes an Error **
> argument is suspicious. qemu_fsdev_add() does that, and its caller
> fsdev_init_func() then fails without setting an error. Its caller
> main(), via qemu_opts_f
On 10/8/18 12:31 PM, Markus Armbruster wrote:
Calling error_report() from within a a function that takes an Error **
s/a a/a/
argument is suspicious. qemu_fsdev_add() does that, and its caller
fsdev_init_func() then fails without setting an error. Its caller
main(), via qemu_opts_foreach(),
Calling error_report() from within a a function that takes an Error **
argument is suspicious. qemu_fsdev_add() does that, and its caller
fsdev_init_func() then fails without setting an error. Its caller
main(), via qemu_opts_foreach(), is fine with it, but clean it up
anyway.
Cc: Greg Kurz
Sig