Re: [Qemu-devel] [PATCH 26/37] sd: free timer

2016-07-21 Thread Andrew Baumann
, Jul 19, 2016 at 12:54 PM > Subject: [Qemu-devel] [PATCH 26/37] sd: free timer > To: qemu-devel@nongnu.org > Cc: Marc-André Lureau > > > From: Marc-André Lureau > > Free the timer allocated in instance_init. > > Signed-off-by: Marc-André Lureau > --- > hw/sd

Re: [Qemu-devel] [PATCH 26/37] sd: free timer

2016-07-21 Thread Marc-André Lureau
Hi On Thu, Jul 21, 2016 at 8:53 PM, Andrew Baumann wrote: > Thanks for the fix. This was based on some other timer code I found in the > tree that was evidently also leaky (I don't remember where unfortunately). > > One thing: are you sure it is safe to call timer_del() again if the timer may >

[Qemu-devel] [PATCH 26/37] sd: free timer

2016-07-19 Thread marcandre . lureau
From: Marc-André Lureau Free the timer allocated in instance_init. Signed-off-by: Marc-André Lureau --- hw/sd/sd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 87c6dc1..8e88e83 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1876,6 +1876,14 @@ static