Re: [Qemu-devel] [PATCH 26/29] vmsvga: Add basic support for display topology

2018-08-13 Thread Gerd Hoffmann
Hi, > These registers are suppose to indicate to guest the display monitor > size (width & height). > Thus, wiring up GraphicsHwOps->ui_info callback to return new info on > SVGA_REG_DISPLAY_{WIDTH, HEIGHT} registers may be useful only for case > that we want guest to respond to the fact that t

Re: [Qemu-devel] [PATCH 26/29] vmsvga: Add basic support for display topology

2018-08-10 Thread Liran Alon
> On 10 Aug 2018, at 12:56, Gerd Hoffmann wrote: > > Hi, > >> +case SVGA_REG_DISPLAY_WIDTH: >> +if ((s->display_id == 0) || (s->display_id == SVGA_ID_INVALID)) >> +ret = s->new_width ? s->new_width : surface_width(surface); >> +else >> +ret = 0; >>

Re: [Qemu-devel] [PATCH 26/29] vmsvga: Add basic support for display topology

2018-08-10 Thread Gerd Hoffmann
Hi, > +case SVGA_REG_DISPLAY_WIDTH: > +if ((s->display_id == 0) || (s->display_id == SVGA_ID_INVALID)) > +ret = s->new_width ? s->new_width : surface_width(surface); > +else > +ret = 0; > +break; > +case SVGA_REG_DISPLAY_HEIGHT: > +

[Qemu-devel] [PATCH 26/29] vmsvga: Add basic support for display topology

2018-08-09 Thread Liran Alon
From: Leonid Shatz Report SVGA_CAP_DISPLAY_TOPOLOGY capability and support single legacy screen at fixed offset of (0,0). This is a pre-requesite for supporting PITCHLOCK feature which is required by Linux kernel vmsvga driver (See Linux kernel vmw_driver_load()). Signed-off-by: Leonid Shatz R