Re: [Qemu-devel] [PATCH 25/28] ahci: add test_pci_enable to ahci-test.

2014-07-31 Thread Stefan Hajnoczi
On Mon, Jul 07, 2014 at 02:18:06PM -0400, John Snow wrote: > +/* Test the Q35/ICH9 behavior in preference to AHCI 1.3 behavior */ > +#define Q35 > + > +#ifndef Q35 > +#define AHCI_13_STRICT > +#endif > + Please don't use an #ifdef. If you really want to keep both code paths around, make it a C va

[Qemu-devel] [PATCH 25/28] ahci: add test_pci_enable to ahci-test.

2014-07-07 Thread John Snow
This adds a test wherein we engage the PCI AHCI device and ensure that the memory region for the HBA functionality is now accessible. Under Q35 environments, additional PCI configuration is performed to ensure that the HBA functionality will become usable. Signed-off-by: John Snow --- tests/ahc