Re: [Qemu-devel] [PATCH 24/27] grackle: remove broken pci device

2012-01-02 Thread Anthony Liguori
On 01/02/2012 04:41 PM, Andreas Färber wrote: Am 20.12.2011 17:51, schrieb Anthony Liguori: I have no idea what's going on here, but this is broken and cannot possibly work because: 1) It's qdev name conflicts with a device that sits on SysBus 2) The PCI constructor expects a SysBus device

Re: [Qemu-devel] [PATCH 24/27] grackle: remove broken pci device

2012-01-02 Thread Andreas Färber
Am 20.12.2011 17:51, schrieb Anthony Liguori: > I have no idea what's going on here, but this is broken and cannot possibly > work because: > > 1) It's qdev name conflicts with a device that sits on SysBus > > 2) The PCI constructor expects a SysBus device... but's it's a PCIDevice > > If you

[Qemu-devel] [PATCH 24/27] grackle: remove broken pci device

2011-12-20 Thread Anthony Liguori
I have no idea what's going on here, but this is broken and cannot possibly work because: 1) It's qdev name conflicts with a device that sits on SysBus 2) The PCI constructor expects a SysBus device... but's it's a PCIDevice If you do qdev_create("grackle"), the code expects to get the SysBus