Re: [Qemu-devel] [PATCH 24/26] libcacard: move atr setting from macro to function

2013-03-22 Thread Alon Levy
> Hi, > > review below > > On Mon, Mar 18, 2013 at 2:11 PM, Alon Levy wrote: > > Only because qemu's checkpatch complains about it. > > > > Signed-off-by: Alon Levy > > --- > > Makefile.objs | 1 + > > libcacard/vcard_emul_nss.c | 11 --- > > libcacard/vcardt.c |

Re: [Qemu-devel] [PATCH 24/26] libcacard: move atr setting from macro to function

2013-03-22 Thread Marc-André Lureau
Hi, review below On Mon, Mar 18, 2013 at 2:11 PM, Alon Levy wrote: > Only because qemu's checkpatch complains about it. > > Signed-off-by: Alon Levy > --- > Makefile.objs | 1 + > libcacard/vcard_emul_nss.c | 11 --- > libcacard/vcardt.c | 40 +

[Qemu-devel] [PATCH 24/26] libcacard: move atr setting from macro to function

2013-03-18 Thread Alon Levy
Only because qemu's checkpatch complains about it. Signed-off-by: Alon Levy --- Makefile.objs | 1 + libcacard/vcard_emul_nss.c | 11 --- libcacard/vcardt.c | 40 libcacard/vcardt.h | 15 ++- 4 files chang