Il 29/04/2014 11:44, Michael S. Tsirkin ha scritto:
> I disagree. In fact, I think the opposite is true: the three
> functions you mention should take a PCIDevice*, and when this is
> done acpi_memory_plug_cb should be changed to take a DIMMDevice*
> too.
Well this just means we'll need another
On Tue, Apr 29, 2014 at 10:49:16AM +0200, Paolo Bonzini wrote:
> Il 29/04/2014 09:25, Michael S. Tsirkin ha scritto:
> >But to repeat what I was saying, this check (that object passed in
> >is a PCI DEVICE) belongs in acpi_pcihp_device_plug_cb and should not be
> >piix specific, I don't want to dup
Il 29/04/2014 09:25, Michael S. Tsirkin ha scritto:
But to repeat what I was saying, this check (that object passed in
is a PCI DEVICE) belongs in acpi_pcihp_device_plug_cb and should not be
piix specific, I don't want to duplicate this logic in q35 later.
Similar checks should be added in
shpc_d
On Fri, Apr 11, 2014 at 09:40:19PM -0400, Paolo Bonzini wrote:
> Il 07/04/2014 11:19, Michael S. Tsirkin ha scritto:
> >This means we can't cleanly implement an option for guest to
> >disable ACPI and switch to native if supported,
> >like the ACPI spec allows.
> >
> >If we change hotplug code to w
On Tue, Apr 29, 2014 at 10:12:34AM +0200, Paolo Bonzini wrote:
> Il 07/04/2014 17:36, Michael S. Tsirkin ha scritto:
> >>> * What if there would be more handlers that could or should handle event
> >>>for device?
> >That's actually very useful. We could scan top to bottom
> >so e.g. acpi can i
Il 07/04/2014 17:36, Michael S. Tsirkin ha scritto:
> * What if there would be more handlers that could or should handle event
>for device?
That's actually very useful. We could scan top to bottom
so e.g. acpi can intercept bridges.
Be careful about "top to bottom". Does top-to-bottom m
Il 07/04/2014 11:19, Michael S. Tsirkin ha scritto:
This means we can't cleanly implement an option for guest to
disable ACPI and switch to native if supported,
like the ACPI spec allows.
If we change hotplug code to walk the tree top down
and invoke all callbacks, then it will be fixed
in a cle
On Mon, 7 Apr 2014 18:36:34 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Apr 07, 2014 at 04:22:06PM +0200, Igor Mammedov wrote:
> > On Mon, 7 Apr 2014 16:25:30 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote:
> > > > On Mon, 7 Apr 201
On Mon, Apr 07, 2014 at 04:22:06PM +0200, Igor Mammedov wrote:
> On Mon, 7 Apr 2014 16:25:30 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote:
> > > On Mon, 7 Apr 2014 15:07:15 +0300
> > > "Michael S. Tsirkin" wrote:
> > >
> > > > On Mon, A
On Mon, Apr 07, 2014 at 04:25:30PM +0300, Michael S. Tsirkin wrote:
> On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote:
> > On Mon, 7 Apr 2014 15:07:15 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote:
> > > > On Mon, 7 Apr
On Mon, 7 Apr 2014 16:25:30 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote:
> > On Mon, 7 Apr 2014 15:07:15 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote:
> > > > On Mon, 7 Apr 201
On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote:
> On Mon, 7 Apr 2014 15:07:15 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote:
> > > On Mon, 7 Apr 2014 14:32:41 +0300
> > > "Michael S. Tsirkin" wrote:
> > >
> > > > On Fri, A
On Mon, 7 Apr 2014 15:07:15 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote:
> > On Mon, 7 Apr 2014 14:32:41 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote:
> > > > ... and report er
On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote:
> On Mon, 7 Apr 2014 14:32:41 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote:
> > > ... and report error if plugged in device is not supported.
> > > Later generic callbacks wil
On Mon, 7 Apr 2014 14:32:41 +0300
"Michael S. Tsirkin" wrote:
> On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote:
> > ... and report error if plugged in device is not supported.
> > Later generic callbacks will be used by memory hotplug.
> >
> > Signed-off-by: Igor Mammedov
>
>
>
On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote:
> ... and report error if plugged in device is not supported.
> Later generic callbacks will be used by memory hotplug.
>
> Signed-off-by: Igor Mammedov
OK in that case, how about teaching all hotplug callbacks about this?
There ar
... and report error if plugged in device is not supported.
Later generic callbacks will be used by memory hotplug.
Signed-off-by: Igor Mammedov
---
hw/acpi/piix4.c | 31 ++-
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix
17 matches
Mail list logo
