Re: [Qemu-devel] [PATCH 23/28] ahci: Adding basic functionality qtest.

2014-07-31 Thread Stefan Hajnoczi
On Mon, Jul 07, 2014 at 02:18:04PM -0400, John Snow wrote: > +/* To help make it clear that the HBA is not a pointer to local memory. */ > +typedef void HBA; Unused. Please drop it or move it to the patch that uses it. > +static void free_ahci_device(QPCIDevice *ahci) > +{ > +if (pcibus) { >

[Qemu-devel] [PATCH 23/28] ahci: Adding basic functionality qtest.

2014-07-07 Thread John Snow
Currently, there is no qtest to test the functionality of the AHCI functionality present within the Q35 machine type. This patch adds a skeleton for an AHCI test suite, and adds a simple sanity-check test case where we identify that the AHCI device is present, then disengage the virtual machine.