Re: [Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-05-08 Thread Max Filippov
On Tue, Apr 30, 2019 at 2:07 PM Max Filippov wrote: > On Tue, Apr 30, 2019 at 11:14 AM Max Filippov wrote: > > On Tue, Apr 30, 2019 at 10:44 AM Richard Henderson > > > And Peter's right that I should have kept EXC_USER. > > It appears to work as is: the EXC_USER is set up by the > exception_cause

Re: [Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-04-30 Thread Max Filippov
On Tue, Apr 30, 2019 at 11:14 AM Max Filippov wrote: > On Tue, Apr 30, 2019 at 10:44 AM Richard Henderson > > And Peter's right that I should have kept EXC_USER. It appears to work as is: the EXC_USER is set up by the exception_cause helper because there's always PS_U in the PS, PS_EXCM is cleare

Re: [Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-04-30 Thread Max Filippov
On Tue, Apr 30, 2019 at 10:44 AM Richard Henderson wrote: > On 4/30/19 10:32 AM, Max Filippov wrote: > > On Tue, Apr 30, 2019 at 3:11 AM Peter Maydell > > wrote: > >> ...but now we'll set it to whatever exception_cause_vaddr does, > >> which is something more complicated based on the state of >

Re: [Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-04-30 Thread Richard Henderson
On 4/30/19 10:32 AM, Max Filippov wrote: > On Tue, Apr 30, 2019 at 3:11 AM Peter Maydell > wrote: >> >> On Wed, 3 Apr 2019 at 05:00, Richard Henderson >> wrote: >>> >>> Cc: Max Filippov >>> Signed-off-by: Richard Henderson >>> --- >>> target/xtensa/cpu.h| 5 +-- >>> target/xtensa/cpu.c

Re: [Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-04-30 Thread Max Filippov
On Tue, Apr 30, 2019 at 3:11 AM Peter Maydell wrote: > > On Wed, 3 Apr 2019 at 05:00, Richard Henderson > wrote: > > > > Cc: Max Filippov > > Signed-off-by: Richard Henderson > > --- > > target/xtensa/cpu.h| 5 +-- > > target/xtensa/cpu.c| 5 ++- > > target/xtensa/helper.c | 74 +

Re: [Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-04-30 Thread Peter Maydell
On Wed, 3 Apr 2019 at 05:00, Richard Henderson wrote: > > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > target/xtensa/cpu.h| 5 +-- > target/xtensa/cpu.c| 5 ++- > target/xtensa/helper.c | 74 +- > 3 files changed, 42 insertions(+)

[Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Max Filippov Signed-off-by: Richard Henderson --- target/xtensa/cpu.h| 5 +-- target/xtensa/cpu.c| 5 ++- target/xtensa/helper.c | 74 +- 3 files changed, 42 insertions(+), 42 deletions(-) diff --git a/target/xtensa/cpu.h b/target/xtensa/cpu