Re: [Qemu-devel] [PATCH 22/42] job: Move BlockJobCreateFlags to Job

2018-05-16 Thread Kevin Wolf
Am 16.05.2018 um 21:13 hat Eric Blake geschrieben: > On 05/09/2018 11:26 AM, Kevin Wolf wrote: > > This renames the BlockJobCreateFlags constants, moves a few JOB_INTERNAL > > checks to job_create() and the auto_{finalize,dismiss} fields from > > BlockJob to Job. > > Do we still want to allow auto

Re: [Qemu-devel] [PATCH 22/42] job: Move BlockJobCreateFlags to Job

2018-05-16 Thread Eric Blake
On 05/09/2018 11:26 AM, Kevin Wolf wrote: This renames the BlockJobCreateFlags constants, moves a few JOB_INTERNAL checks to job_create() and the auto_{finalize,dismiss} fields from BlockJob to Job. Do we still want to allow auto-finalize on all jobs, or should we keep it just for legacy suppo

Re: [Qemu-devel] [PATCH 22/42] job: Move BlockJobCreateFlags to Job

2018-05-14 Thread Max Reitz
On 2018-05-09 18:26, Kevin Wolf wrote: > This renames the BlockJobCreateFlags constants, moves a few JOB_INTERNAL > checks to job_create() and the auto_{finalize,dismiss} fields from > BlockJob to Job. > > Signed-off-by: Kevin Wolf > --- > include/block/blockjob.h | 17 - > i

[Qemu-devel] [PATCH 22/42] job: Move BlockJobCreateFlags to Job

2018-05-09 Thread Kevin Wolf
This renames the BlockJobCreateFlags constants, moves a few JOB_INTERNAL checks to job_create() and the auto_{finalize,dismiss} fields from BlockJob to Job. Signed-off-by: Kevin Wolf --- include/block/blockjob.h | 17 - include/block/blockjob_int.h | 3 +-- include/qemu/job.