Re: [Qemu-devel] [PATCH 21/38] target-arm: Implement sbc_cc inline

2013-02-25 Thread Richard Henderson
On 2013-02-24 23:43, Peter Crosthwaite wrote: +tcg_gen_movi_i32(tmp, 0); >+tcg_gen_add2_i32(cpu_NF, cpu_CF, t0, tmp, cpu_CF, tmp); Discards NF intermediary result and re-uses operand t0. Regard, Peter >+tcg_gen_sub2_i32(cpu_NF, cpu_CF, t0, cpu_CF, t1, tmp); > Whoops,

Re: [Qemu-devel] [PATCH 21/38] target-arm: Implement sbc_cc inline

2013-02-24 Thread Peter Crosthwaite
Hi All, Same problem as commented on patch 20. On Wed, Feb 20, 2013 at 5:52 PM, Richard Henderson wrote: > Use sub2 if available, otherwise use 64-bit arithmetic. > > Cc: Peter Maydell > Signed-off-by: Richard Henderson > --- > target-arm/helper.h| 2 -- > target-arm/op_helper.c | 15 ---

[Qemu-devel] [PATCH 21/38] target-arm: Implement sbc_cc inline

2013-02-20 Thread Richard Henderson
Use sub2 if available, otherwise use 64-bit arithmetic. Cc: Peter Maydell Signed-off-by: Richard Henderson --- target-arm/helper.h| 2 -- target-arm/op_helper.c | 15 --- target-arm/translate.c | 47 +++ 3 files changed, 39 insertions