Re: [Qemu-devel] [PATCH 2.2 2/2] linux-user: Properly handle timer magic offset

2014-11-10 Thread Alexander Graf
On 10.11.14 17:55, Peter Maydell wrote: > On 10 November 2014 16:46, Alexander Graf wrote: >> When creating a timer handle, we give the timer id a special magic offset >> of 0xcafe. However, we never mask that offset out of the timer id before >> we start using it to dereference our timer ar

Re: [Qemu-devel] [PATCH 2.2 2/2] linux-user: Properly handle timer magic offset

2014-11-10 Thread Peter Maydell
On 10 November 2014 16:46, Alexander Graf wrote: > When creating a timer handle, we give the timer id a special magic offset > of 0xcafe. However, we never mask that offset out of the timer id before > we start using it to dereference our timer array. So we always end up aborting > timer opera

[Qemu-devel] [PATCH 2.2 2/2] linux-user: Properly handle timer magic offset

2014-11-10 Thread Alexander Graf
When creating a timer handle, we give the timer id a special magic offset of 0xcafe. However, we never mask that offset out of the timer id before we start using it to dereference our timer array. So we always end up aborting timer operations because the timer id is out of bounds. This was not