Re: [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use

2015-01-14 Thread Markus Armbruster
Eric Blake writes: > On 01/13/2015 10:50 AM, Markus Armbruster wrote: >> Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose, >> probably because adding another error seemed cumbersome overkill. >> Produces "No spice device has been activated", which is awkward. >> >> We've since aband

Re: [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose, > probably because adding another error seemed cumbersome overkill. > Produces "No spice device has been activated", which is awkward. > > We've since abandoned our quest for "rich" er

[Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use

2015-01-13 Thread Markus Armbruster
Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose, probably because adding another error seemed cumbersome overkill. Produces "No spice device has been activated", which is awkward. We've since abandoned our quest for "rich" error objects. Time to undo the damage to this error message