Re: [Qemu-devel] [PATCH 2/8] block: add live block commit functionality

2012-09-14 Thread Jeff Cody
On 09/14/2012 02:23 PM, Eric Blake wrote: > On 09/14/2012 10:07 AM, Jeff Cody wrote: >>> Question: is it valid to have a qcow2 file whose size is smaller than >>> it's backing image? >> >> I don't think so... however: >> >>> Suppose I have base[1M] <- mid[2M] <- top[3M] <- >>> active[3M], and requ

Re: [Qemu-devel] [PATCH 2/8] block: add live block commit functionality

2012-09-14 Thread Eric Blake
On 09/14/2012 10:07 AM, Jeff Cody wrote: >> Question: is it valid to have a qcow2 file whose size is smaller than >> it's backing image? > > I don't think so... however: > >> Suppose I have base[1M] <- mid[2M] <- top[3M] <- >> active[3M], and request to commit top into base. This bdrv_truncate(

Re: [Qemu-devel] [PATCH 2/8] block: add live block commit functionality

2012-09-14 Thread Jeff Cody
On 09/14/2012 11:45 AM, Eric Blake wrote: > On 09/14/2012 07:41 AM, Jeff Cody wrote: >> This adds the live commit coroutine. This iteration focuses on the >> commit only below the active layer, and not the active layer itself. >> >> The behaviour is similar to block streaming; the sectors are walk

Re: [Qemu-devel] [PATCH 2/8] block: add live block commit functionality

2012-09-14 Thread Eric Blake
On 09/14/2012 07:41 AM, Jeff Cody wrote: > This adds the live commit coroutine. This iteration focuses on the > commit only below the active layer, and not the active layer itself. > > The behaviour is similar to block streaming; the sectors are walked > through, and anything that exists above 'b

[Qemu-devel] [PATCH 2/8] block: add live block commit functionality

2012-09-14 Thread Jeff Cody
This adds the live commit coroutine. This iteration focuses on the commit only below the active layer, and not the active layer itself. The behaviour is similar to block streaming; the sectors are walked through, and anything that exists above 'base' is committed back down into base. At the end,