Re: [Qemu-devel] [PATCH 2/7] runstate: Add runstate store

2014-10-22 Thread Eric Blake
On 10/22/2014 05:40 AM, Markus Armbruster wrote: >> I think the question here really comes from RunState being an enum defined >> in qapi-schema.json; so we could use that directly in the migration stream >> if we were guaranteed that the encoding of that enum wasn't going to change. >> Does qapi m

Re: [Qemu-devel] [PATCH 2/7] runstate: Add runstate store

2014-10-22 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Eric Blake (ebl...@redhat.com) wrote: >> On 10/20/2014 04:52 AM, Juan Quintela wrote: >> > "Dr. David Alan Gilbert" wrote: >> >> * Juan Quintela (quint...@redhat.com) wrote: >> >>> This allows us to store the current state to send it through migration. >> >>

Re: [Qemu-devel] [PATCH 2/7] runstate: Add runstate store

2014-10-22 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 10/20/2014 04:52 AM, Juan Quintela wrote: > > "Dr. David Alan Gilbert" wrote: > >> * Juan Quintela (quint...@redhat.com) wrote: > >>> This allows us to store the current state to send it through migration. > >> > >> Why store the runstate as a string?

Re: [Qemu-devel] [PATCH 2/7] runstate: Add runstate store

2014-10-20 Thread Eric Blake
On 10/20/2014 04:52 AM, Juan Quintela wrote: > "Dr. David Alan Gilbert" wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >>> This allows us to store the current state to send it through migration. >> >> Why store the runstate as a string? The later code then ends up doing >> string compares

Re: [Qemu-devel] [PATCH 2/7] runstate: Add runstate store

2014-10-20 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> This allows us to store the current state to send it through migration. > > Why store the runstate as a string? The later code then ends up doing > string compares and things - why not just use the enum value? How

Re: [Qemu-devel] [PATCH 2/7] runstate: Add runstate store

2014-10-20 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This allows us to store the current state to send it through migration. Why store the runstate as a string? The later code then ends up doing string compares and things - why not just use the enum value? Dave > Signed-off-by: Juan Quintela > --- >

[Qemu-devel] [PATCH 2/7] runstate: Add runstate store

2014-10-15 Thread Juan Quintela
This allows us to store the current state to send it through migration. Signed-off-by: Juan Quintela --- include/sysemu/sysemu.h | 1 + vl.c| 10 ++ 2 files changed, 11 insertions(+) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index d8539fd..ae217