Re: [Qemu-devel] [PATCH 2/7] migration: only flush when there are no errors

2011-09-20 Thread Paolo Bonzini
On 09/20/2011 03:24 PM, Juan Quintela wrote: If we have one error while migrating, and then we issuse a "migrate_cancel" command, guest hang. Fix it for flushing only when migration is in MIG_STATE_ACTIVE. In case of error of cancellation, don't flush. We had an infinite loop at buffered_close

Re: [Qemu-devel] [PATCH 2/7] migration: only flush when there are no errors

2011-09-20 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Tue, Sep 20, 2011 at 03:24:41PM +0200, Juan Quintela wrote: >> If we have one error while migrating, and then we issuse a >> "migrate_cancel" command, guest hang. Fix it for flushing only when >> migration is in MIG_STATE_ACTIVE. In case of error of cancellation,

Re: [Qemu-devel] [PATCH 2/7] migration: only flush when there are no errors

2011-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2011 at 03:24:41PM +0200, Juan Quintela wrote: > If we have one error while migrating, and then we issuse a > "migrate_cancel" command, guest hang. Fix it for flushing only when > migration is in MIG_STATE_ACTIVE. In case of error of cancellation, > don't flush. > > We had an inf

[Qemu-devel] [PATCH 2/7] migration: only flush when there are no errors

2011-09-20 Thread Juan Quintela
If we have one error while migrating, and then we issuse a "migrate_cancel" command, guest hang. Fix it for flushing only when migration is in MIG_STATE_ACTIVE. In case of error of cancellation, don't flush. We had an infinite loop at buffered_close() while (!s->has_error && s->buffer_s