Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-03-06 Thread Juan Quintela
Gonglei wrote: > On 2014/3/6 0:18, Juan Quintela wrote: > >> "Gonglei (Arei)" wrote: >>> Add counters to log the times of updating the dirty bitmap. >>> >>> Signed-off-by: ChenLiang >>> Signed-off-by: Gonglei >> >> As told by Eric, I am with this change, but can we move the code to the >> same

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-03-06 Thread Gonglei
On 2014/3/6 0:18, Juan Quintela wrote: > "Gonglei (Arei)" wrote: >> Add counters to log the times of updating the dirty bitmap. >> >> Signed-off-by: ChenLiang >> Signed-off-by: Gonglei > > As told by Eric, I am with this change, but can we move the code to the > same place that the rest of the

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-03-05 Thread Juan Quintela
"Gonglei (Arei)" wrote: > Add counters to log the times of updating the dirty bitmap. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei As told by Eric, I am with this change, but can we move the code to the same place that the rest of the statistics? Thanks, Juan.

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-02-28 Thread 陈梁
> On 02/27/2014 09:08 PM, Gonglei (Arei) wrote: >> Add counters to log the times of updating the dirty bitmap. >> >> Signed-off-by: ChenLiang >> Signed-off-by: Gonglei >> --- >> arch_init.c | 20 >> 1 file changed, 20 insertions(+) > > Is it also worth updating MigrationSta

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-02-28 Thread Eric Blake
On 02/27/2014 09:08 PM, Gonglei (Arei) wrote: > Add counters to log the times of updating the dirty bitmap. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > arch_init.c | 20 > 1 file changed, 20 insertions(+) Is it also worth updating MigrationStats in qapi-s

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-02-28 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: > Add counters to log the times of updating the dirty bitmap. Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > arch_init.c | 20 > 1 file changed, 20 insertions(+) > > diff -

[Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-02-27 Thread Gonglei (Arei)
Add counters to log the times of updating the dirty bitmap. Signed-off-by: ChenLiang Signed-off-by: Gonglei --- arch_init.c | 20 1 file changed, 20 insertions(+) diff --git a/arch_init.c b/arch_init.c index bc8d0eb..6823c5a 100644 --- a/arch_init.c +++ b/arch_init.c @@ -1