Re: [Qemu-devel] [PATCH 2/7] integratorcp: convert icp pic to memory API

2011-10-18 Thread Peter Maydell
2011/10/17 Benoît Canet : > Signed-off-by: Benoit Canet > --- >  hw/integratorcp.c |   27 ++- >  1 files changed, 10 insertions(+), 17 deletions(-) Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH 2/7] integratorcp: convert icp pic to memory API

2011-10-17 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/integratorcp.c | 27 ++- 1 files changed, 10 insertions(+), 17 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 0dc84c4..c7d6596 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -279,6 +279,7 @@ static int

Re: [Qemu-devel] [PATCH 2/7] integratorcp: convert icp pic to memory API

2011-10-17 Thread Peter Maydell
2011/10/13 Benoît Canet : This patch is OK for content but it has a number of lines with huge amounts of trailing whitespace. If you run your patches through scripts/checkpatch.pl before sending it will catch this and other minor style errors. -- PMM

[Qemu-devel] [PATCH 2/7] integratorcp: convert icp pic to memory API

2011-10-13 Thread Benoît Canet
--- hw/integratorcp.c | 29 +++-- 1 files changed, 11 insertions(+), 18 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 0dc84c4..e3a5f24 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -279,6 +279,7 @@ static int integratorcm_init(SysBusDe