Re: [Qemu-devel] [PATCH 2/7] block: Add Error parameter to bdrv_amend_options

2018-05-02 Thread Max Reitz
On 2018-05-02 19:52, Eric Blake wrote: > On 04/21/2018 11:54 AM, Max Reitz wrote: >> Looking at the qcow2 code that is riddled with error_report() calls, >> this is really how it should have been from the start. >> >> Signed-off-by: Max Reitz >> --- > >> +++ b/block/qcow2.c >> @@ -4049,7 +4049,8

Re: [Qemu-devel] [PATCH 2/7] block: Add Error parameter to bdrv_amend_options

2018-05-02 Thread Eric Blake
On 04/21/2018 11:54 AM, Max Reitz wrote: Looking at the qcow2 code that is riddled with error_report() calls, this is really how it should have been from the start. Signed-off-by: Max Reitz --- +++ b/block/qcow2.c @@ -4049,7 +4049,8 @@ static int qcow2_load_vmstate(BlockDriverState *bs, QEM

[Qemu-devel] [PATCH 2/7] block: Add Error parameter to bdrv_amend_options

2018-04-21 Thread Max Reitz
Looking at the qcow2 code that is riddled with error_report() calls, this is really how it should have been from the start. Signed-off-by: Max Reitz --- include/block/block.h | 3 +- include/block/block_int.h | 3 +- block.c| 8 -- block/qcow2.c | 72