Re: [Qemu-devel] [PATCH 2/6] spapr: fix error path of required kernel-irqchip

2017-05-15 Thread Greg Kurz
On Tue, 16 May 2017 16:08:46 +1000 David Gibson wrote: > On Tue, May 16, 2017 at 07:56:05AM +0200, Greg Kurz wrote: > > On Tue, 16 May 2017 14:35:55 +1000 > > David Gibson wrote: > > > > > On Mon, May 15, 2017 at 01:39:26PM +0200, Greg Kurz wrote: > > > > QEMU should exit if the user explic

Re: [Qemu-devel] [PATCH 2/6] spapr: fix error path of required kernel-irqchip

2017-05-15 Thread David Gibson
On Tue, May 16, 2017 at 07:56:05AM +0200, Greg Kurz wrote: > On Tue, 16 May 2017 14:35:55 +1000 > David Gibson wrote: > > > On Mon, May 15, 2017 at 01:39:26PM +0200, Greg Kurz wrote: > > > QEMU should exit if the user explicitely asked for kernel-irqchip support > > > and "xics-kvm" initializatio

Re: [Qemu-devel] [PATCH 2/6] spapr: fix error path of required kernel-irqchip

2017-05-15 Thread Greg Kurz
On Tue, 16 May 2017 14:35:55 +1000 David Gibson wrote: > On Mon, May 15, 2017 at 01:39:26PM +0200, Greg Kurz wrote: > > QEMU should exit if the user explicitely asked for kernel-irqchip support > > and "xics-kvm" initialization fails. > > > > The changelog of commit 34f2af3d3edf ("spapr: Clean u

Re: [Qemu-devel] [PATCH 2/6] spapr: fix error path of required kernel-irqchip

2017-05-15 Thread David Gibson
On Mon, May 15, 2017 at 01:39:26PM +0200, Greg Kurz wrote: > QEMU should exit if the user explicitely asked for kernel-irqchip support > and "xics-kvm" initialization fails. > > The changelog of commit 34f2af3d3edf ("spapr: Clean up misuse of qdev_init() > in xics-kvm creation") reads: > > Wh

Re: [Qemu-devel] [PATCH 2/6] spapr: fix error path of required kernel-irqchip

2017-05-15 Thread Cédric Le Goater
On 05/15/2017 01:39 PM, Greg Kurz wrote: > QEMU should exit if the user explicitely asked for kernel-irqchip support > and "xics-kvm" initialization fails. > > The changelog of commit 34f2af3d3edf ("spapr: Clean up misuse of qdev_init() > in xics-kvm creation") reads: > > While there, improve

[Qemu-devel] [PATCH 2/6] spapr: fix error path of required kernel-irqchip

2017-05-15 Thread Greg Kurz
QEMU should exit if the user explicitely asked for kernel-irqchip support and "xics-kvm" initialization fails. The changelog of commit 34f2af3d3edf ("spapr: Clean up misuse of qdev_init() in xics-kvm creation") reads: While there, improve the error message when we can't satisfy an explici