On Tue, Sep 10, 2013 at 6:59 PM, Andreas Färber wrote:
> Am 10.09.2013 18:49, schrieb Paolo Bonzini:
>> Il 10/09/2013 18:21, Stefan Hajnoczi ha scritto:
>>> qdev_device_add() leaks the created qdev upon failure. I suspect this
>>> problem crept in because qdev_free() unparents the qdev but does n
Il 10/09/2013 18:59, Andreas Färber ha scritto:
> Am 10.09.2013 18:49, schrieb Paolo Bonzini:
>> Il 10/09/2013 18:21, Stefan Hajnoczi ha scritto:
>>> qdev_device_add() leaks the created qdev upon failure. I suspect this
>>> problem crept in because qdev_free() unparents the qdev but does not
>>> d
Il 10/09/2013 18:21, Stefan Hajnoczi ha scritto:
> qdev_device_add() leaks the created qdev upon failure. I suspect this
> problem crept in because qdev_free() unparents the qdev but does not
> drop a reference - confusing name.
Right, the name a leftover from pre-refcounting days.
BTW, not drop
Am 10.09.2013 18:49, schrieb Paolo Bonzini:
> Il 10/09/2013 18:21, Stefan Hajnoczi ha scritto:
>> qdev_device_add() leaks the created qdev upon failure. I suspect this
>> problem crept in because qdev_free() unparents the qdev but does not
>> drop a reference - confusing name.
>
> Right, the name
qdev_device_add() leaks the created qdev upon failure. I suspect this
problem crept in because qdev_free() unparents the qdev but does not
drop a reference - confusing name.
Also drop trailing whitespace after curly bracket.
Signed-off-by: Stefan Hajnoczi
---
qdev-monitor.c | 4 +++-
1 file ch
