Re: [Qemu-devel] [PATCH 2/6] memory: change dirty setting APIs to take a size

2011-12-12 Thread Juan Quintela
Blue Swirl wrote: > Instead of each target knowing or guessing the guest page size, > just pass the desired size of dirtied memory area. This should also > improve performance due to memset() optimizations. My understanding last time I looked at this, is that it is as easy basically to change the

Re: [Qemu-devel] [PATCH 2/6] memory: change dirty setting APIs to take a size

2011-12-11 Thread Avi Kivity
On 12/10/2011 06:44 PM, Blue Swirl wrote: > Instead of each target knowing or guessing the guest page size, > just pass the desired size of dirtied memory area. This should also > improve performance due to memset() optimizations. > > > -static inline void cpu_physical_memory_set_dirty(ram_addr_t a

[Qemu-devel] [PATCH 2/6] memory: change dirty setting APIs to take a size

2011-12-10 Thread Blue Swirl
Instead of each target knowing or guessing the guest page size, just pass the desired size of dirtied memory area. This should also improve performance due to memset() optimizations. Signed-off-by: Blue Swirl --- arch_init.c |3 ++- cpu-all.h |9 +++-- hw/cirrus_vga.c | 1