Re: [Qemu-devel] [PATCH 2/6] block: Check if block drivers can do copy offloading

2018-06-15 Thread Stefan Hajnoczi
On Fri, Jun 08, 2018 at 02:04:13PM +0800, Fam Zheng wrote: > This avoids the wasteful cluster allocation in qcow2 before actually > trying an unsupported copy range call, for example. I don't understand how this function can work. dst is never traversed so does it always return false? > > Signe

[Qemu-devel] [PATCH 2/6] block: Check if block drivers can do copy offloading

2018-06-07 Thread Fam Zheng
This avoids the wasteful cluster allocation in qcow2 before actually trying an unsupported copy range call, for example. Signed-off-by: Fam Zheng --- block.c | 12 block/file-posix.c| 9 + block/io.c| 3 +++ block/iscsi.c