Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259

2015-03-31 Thread David Gibson
On Tue, Mar 31, 2015 at 11:57:28AM +0200, Markus Armbruster wrote: > David Gibson writes: > > > On Mon, Mar 30, 2015 at 10:37:45AM +0200, Markus Armbruster wrote: > [...] > >> This adds "info irq" and "info pic" to the targets that didn't have them > >> before, implemented by i8259.c's hmp_info_p

Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259

2015-03-31 Thread Peter Maydell
On 6 March 2015 at 04:18, David Gibson wrote: > The hmp commands "irq" and "pic" are a bit of a mess. They're implemented > on a number of targets, but not all. On sparc32 and LM32 they do target > specific things, but on the remainder (i386, ppc and mips) they call into > the i8259 PIC code. >

Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259

2015-03-31 Thread Markus Armbruster
David Gibson writes: > On Mon, Mar 30, 2015 at 10:37:45AM +0200, Markus Armbruster wrote: [...] >> This adds "info irq" and "info pic" to the targets that didn't have them >> before, implemented by i8259.c's hmp_info_pic() and hmp_info_irq(). >> They do nothing unless the machine has an "isa-i825

Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259

2015-03-30 Thread David Gibson
On Mon, Mar 30, 2015 at 10:37:45AM +0200, Markus Armbruster wrote: > Markus Armbruster writes: > > > David Gibson writes: > > > >> The hmp commands "irq" and "pic" are a bit of a mess. They're implemented > >> on a number of targets, but not all. On sparc32 and LM32 they do target > >> specifi

Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259

2015-03-30 Thread Andreas Färber
Am 06.03.2015 um 05:18 schrieb David Gibson: > The hmp commands "irq" and "pic" are a bit of a mess. They're implemented > on a number of targets, but not all. On sparc32 and LM32 they do target > specific things, but on the remainder (i386, ppc and mips) they call into > the i8259 PIC code. > >

Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259

2015-03-30 Thread Markus Armbruster
Markus Armbruster writes: > David Gibson writes: > >> The hmp commands "irq" and "pic" are a bit of a mess. They're implemented >> on a number of targets, but not all. On sparc32 and LM32 they do target >> specific things, but on the remainder (i386, ppc and mips) they call into >> the i8259 P

Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259

2015-03-30 Thread Markus Armbruster
David Gibson writes: > The hmp commands "irq" and "pic" are a bit of a mess. They're implemented > on a number of targets, but not all. On sparc32 and LM32 they do target > specific things, but on the remainder (i386, ppc and mips) they call into > the i8259 PIC code. Where "info pic" does abs

[Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259

2015-03-05 Thread David Gibson
The hmp commands "irq" and "pic" are a bit of a mess. They're implemented on a number of targets, but not all. On sparc32 and LM32 they do target specific things, but on the remainder (i386, ppc and mips) they call into the i8259 PIC code. But really, what these commands do shouldn't be dependen