Re: [Qemu-devel] [PATCH 2/6] Add copy and constant propagation.

2011-05-20 Thread Aurelien Jarno
On Fri, May 20, 2011 at 04:39:29PM +0400, Kirill Batuzov wrote: > Make tcg_constant_folding do copy and constant propagation. It is a > preparational work before actual constant folding. > > Signed-off-by: Kirill Batuzov > --- > tcg/optimize.c | 123 > ++

Re: [Qemu-devel] [PATCH 2/6] Add copy and constant propagation.

2011-05-20 Thread Paolo Bonzini
On 05/20/2011 08:22 PM, Richard Henderson wrote: I think it might be clearer to have these two in a structure, rather than two separate arrays. That does waste a bit of memory in padding for 64-bit target, but I think it might clean up the code a bit. You can use the padding to implement a gen

Re: [Qemu-devel] [PATCH 2/6] Add copy and constant propagation.

2011-05-20 Thread Richard Henderson
On 05/20/2011 05:39 AM, Kirill Batuzov wrote: > +static tcg_target_ulong vals[TCG_MAX_TEMPS]; > +static tcg_temp_state state[TCG_MAX_TEMPS]; Any particular reason to make these static? It's 4-6k on the host stack depending on sizeof tcg_target_ulong. Large, but not excessive. I think it'

[Qemu-devel] [PATCH 2/6] Add copy and constant propagation.

2011-05-20 Thread Kirill Batuzov
Make tcg_constant_folding do copy and constant propagation. It is a preparational work before actual constant folding. Signed-off-by: Kirill Batuzov --- tcg/optimize.c | 123 1 files changed, 123 insertions(+), 0 deletions(-) diff --git