On 4 June 2013 21:59, Alon Levy wrote:
> shouldn't we be looping if EINTR?
Don't open that can of worms if you value your sanity ;-)
-- PMM
> Il 04/06/2013 22:23, Alon Levy ha scritto:
> > This fixes six instances of unchecked fcntl return status, spotted by
> > Coverity.
>
> I think we're just assuming that they cannot fail... I don't think we
> need the previous patch and this one, unless they help porting stuff to
> Windows.
This
> On 4 June 2013 21:23, Alon Levy wrote:
> > --- a/hw/display/qxl.c
> > +++ b/hw/display/qxl.c
> > @@ -1797,15 +1797,11 @@ static void qxl_send_events(PCIQXLDevice *d,
> > uint32_t events)
> >
> > static void init_pipe_signaling(PCIQXLDevice *d)
> > {
> > -if (pipe(d->pipe) < 0) {
> > -
On 4 June 2013 21:23, Alon Levy wrote:
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -1797,15 +1797,11 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t
> events)
>
> static void init_pipe_signaling(PCIQXLDevice *d)
> {
> -if (pipe(d->pipe) < 0) {
> -fprintf(stderr,
Il 04/06/2013 22:23, Alon Levy ha scritto:
> This fixes six instances of unchecked fcntl return status, spotted by
> Coverity.
I think we're just assuming that they cannot fail... I don't think we
need the previous patch and this one, unless they help porting stuff to
Windows.
Paolo
This fixes six instances of unchecked fcntl return status, spotted by
Coverity.
Signed-off-by: Alon Levy
---
hw/display/qxl.c| 10 +++---
hw/usb/ccid-card-emulated.c | 8 +++-
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
