Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-11 Thread Alexey Kardashevskiy
On 12/11/2013 06:59 PM, Alexey Kardashevskiy wrote: > On 12/11/2013 06:47 PM, Paolo Bonzini wrote: >> Il 11/12/2013 06:20, Alexey Kardashevskiy ha scritto: >>> >>> Any progress on this? >>> >>> I am asking since the patchset about bootindex you gave me yesterday prints >>> "(process:38896): GLib-CR

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-11 Thread Alexey Kardashevskiy
On 12/11/2013 06:47 PM, Paolo Bonzini wrote: > Il 11/12/2013 06:20, Alexey Kardashevskiy ha scritto: >> >> Any progress on this? >> >> I am asking since the patchset about bootindex you gave me yesterday prints >> "(process:38896): GLib-CRITICAL **: g_hash_table_foreach: assertion >> `version == ha

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-10 Thread Paolo Bonzini
Il 11/12/2013 06:20, Alexey Kardashevskiy ha scritto: > > Any progress on this? > > I am asking since the patchset about bootindex you gave me yesterday prints > "(process:38896): GLib-CRITICAL **: g_hash_table_foreach: assertion > `version == hash_table->version' failed" which I "fixed" by movin

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-10 Thread Alexey Kardashevskiy
On 12/04/2013 01:58 AM, Paolo Bonzini wrote: > Il 03/12/2013 15:35, Andreas Färber ha scritto: >> Am 03.12.2013 15:00, schrieb Paolo Bonzini: >>> Il 03/12/2013 14:44, Andreas Färber ha scritto: >> >> You can check "if (current_machine && >> current_machine->get_fw_dev_path)", and move c

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-09 Thread Alexey Kardashevskiy
On 12/04/2013 01:00 AM, Paolo Bonzini wrote: > Il 03/12/2013 14:44, Andreas Färber ha scritto: You can check "if (current_machine && current_machine->get_fw_dev_path)", and move current_machine from vl.c to hw/qdev/core.c. >> Please don't encourage moving random stuff into "core

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 15:35, Andreas Färber ha scritto: > Am 03.12.2013 15:00, schrieb Paolo Bonzini: >> Il 03/12/2013 14:44, Andreas Färber ha scritto: > > You can check "if (current_machine && > current_machine->get_fw_dev_path)", and move current_machine from vl.c > to hw/qdev/core.c. >>

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Andreas Färber
Am 03.12.2013 15:00, schrieb Paolo Bonzini: > Il 03/12/2013 14:44, Andreas Färber ha scritto: You can check "if (current_machine && current_machine->get_fw_dev_path)", and move current_machine from vl.c to hw/qdev/core.c. >> Please don't encourage moving random stuff into "core"

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 14:44, Andreas Färber ha scritto: >> > >> > You can check "if (current_machine && >> > current_machine->get_fw_dev_path)", and move current_machine from vl.c >> > to hw/qdev/core.c. > Please don't encourage moving random stuff into "core" device code. > > If needed, we can easily ad

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Andreas Färber
Am 03.12.2013 10:37, schrieb Paolo Bonzini: > Il 25/11/2013 08:27, Alexey Kardashevskiy ha scritto: >> QEMU supports firmware names for all devices in the QEMU tree but >> sometime the exact format differs from what sPAPR platform uses. >> >> This introduces a callback to let a machine fix device t

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Andreas Färber
Am 03.12.2013 04:52, schrieb Alexey Kardashevskiy: > On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: >> Hi! >> >> btw there is a problem with this patch - it does not compile for >> "linux-user" as there is no current-machine global variable defined in vl.c >> which is not compiled for linux-us

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 10:32, Alexey Kardashevskiy ha scritto: >> > Absolutely not. It's merely not portable to machines with object file >> > formats and linkers stuck in the 80s. However, we routinely twist >> > ourselves into knots for portability (observation, not endorsement), and >> > at least one p

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 25/11/2013 08:27, Alexey Kardashevskiy ha scritto: > QEMU supports firmware names for all devices in the QEMU tree but > sometime the exact format differs from what sPAPR platform uses. > > This introduces a callback to let a machine fix device tree path names. > > Signed-off-by: Alexey Kardas

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Alexey Kardashevskiy
On 12/03/2013 08:11 PM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: >>> Hi! >>> >>> btw there is a problem with this patch - it does not compile for >>> "linux-user" as there is no current-machine global variable defined in vl.c

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: >> Hi! >> >> btw there is a problem with this patch - it does not compile for >> "linux-user" as there is no current-machine global variable defined in vl.c >> which is not compiled for linux-user. >> >> How to s

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-02 Thread Alexey Kardashevskiy
On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: > Hi! > > btw there is a problem with this patch - it does not compile for > "linux-user" as there is no current-machine global variable defined in vl.c > which is not compiled for linux-user. > > How to solve this problem correctly? > > > On

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-11-25 Thread Alexey Kardashevskiy
Hi! btw there is a problem with this patch - it does not compile for "linux-user" as there is no current-machine global variable defined in vl.c which is not compiled for linux-user. How to solve this problem correctly? On 11/25/2013 06:27 PM, Alexey Kardashevskiy wrote: > QEMU supports firmwar

[Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-11-24 Thread Alexey Kardashevskiy
QEMU supports firmware names for all devices in the QEMU tree but sometime the exact format differs from what sPAPR platform uses. This introduces a callback to let a machine fix device tree path names. Signed-off-by: Alexey Kardashevskiy --- hw/core/qdev.c | 15 ++- include/hw