Re: [Qemu-devel] [PATCH 2/5] block: Add AioContextNotifier functions to BB

2014-11-18 Thread Paolo Bonzini
On 18/11/2014 10:26, Max Reitz wrote: > However, when you consider (as far as I looked into it) that a BDS is > only closed when there are either no references to it (which will not > happen as long as it has a BB) or when it is ejected, it suddenly does > make sense: "Ejecting" really is something

Re: [Qemu-devel] [PATCH 2/5] block: Add AioContextNotifier functions to BB

2014-11-18 Thread Max Reitz
On 2014-11-17 at 18:26, Paolo Bonzini wrote: On 17/11/2014 16:30, Max Reitz wrote: Because all BlockDriverStates behind a single BlockBackend reside in a single AioContext, it is fine to just pass these functions (blk_add_aio_context_notifier() and blk_remove_aio_context_notifier()) through to t

Re: [Qemu-devel] [PATCH 2/5] block: Add AioContextNotifier functions to BB

2014-11-17 Thread Paolo Bonzini
On 17/11/2014 16:30, Max Reitz wrote: > Because all BlockDriverStates behind a single BlockBackend reside in a > single AioContext, it is fine to just pass these functions > (blk_add_aio_context_notifier() and blk_remove_aio_context_notifier()) > through to the root BlockDriverState. > > Signed-of

[Qemu-devel] [PATCH 2/5] block: Add AioContextNotifier functions to BB

2014-11-17 Thread Max Reitz
Because all BlockDriverStates behind a single BlockBackend reside in a single AioContext, it is fine to just pass these functions (blk_add_aio_context_notifier() and blk_remove_aio_context_notifier()) through to the root BlockDriverState. Signed-off-by: Max Reitz --- block/block-backend.c