Re: [Qemu-devel] [PATCH 2/4 v5] block: Add device-width property to pflash_cfi01

2013-12-03 Thread Roy Franz
On Tue, Dec 3, 2013 at 12:27 PM, Peter Maydell wrote: > On 3 December 2013 20:12, Roy Franz wrote: >> On Thu, Nov 28, 2013 at 11:03 AM, Peter Maydell >> wrote: >>> Other than this and the status (which you deal with in >>> the other patch) the accesses I wonder about whether we >>> have correct

Re: [Qemu-devel] [PATCH 2/4 v5] block: Add device-width property to pflash_cfi01

2013-12-03 Thread Peter Maydell
On 3 December 2013 20:12, Roy Franz wrote: > On Thu, Nov 28, 2013 at 11:03 AM, Peter Maydell > wrote: >> Other than this and the status (which you deal with in >> the other patch) the accesses I wonder about whether we >> have correct are: >> * manufacturer & device ID code read >> * cfi_table[

Re: [Qemu-devel] [PATCH 2/4 v5] block: Add device-width property to pflash_cfi01

2013-12-03 Thread Roy Franz
On Thu, Nov 28, 2013 at 11:03 AM, Peter Maydell wrote: > On 22 October 2013 17:35, Roy Franz wrote: >> The width of the devices that make up the flash interface >> is required to mask certain commands, in particular the >> write length for buffered writes. This length will be presented >> to eac

Re: [Qemu-devel] [PATCH 2/4 v5] block: Add device-width property to pflash_cfi01

2013-11-28 Thread Peter Maydell
On 22 October 2013 17:35, Roy Franz wrote: > The width of the devices that make up the flash interface > is required to mask certain commands, in particular the > write length for buffered writes. This length will be presented > to each device on the interface by the program writing the flash, >

[Qemu-devel] [PATCH 2/4 v5] block: Add device-width property to pflash_cfi01

2013-10-22 Thread Roy Franz
The width of the devices that make up the flash interface is required to mask certain commands, in particular the write length for buffered writes. This length will be presented to each device on the interface by the program writing the flash, and the flash emulation code needs to be able to deter