Re: [Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs

2015-01-13 Thread Paolo Bonzini
On 13/01/2015 19:37, Eduardo Habkost wrote: >> > +tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg, >> > XMM_Q(1)); >> > +tcg_gen_st_i64(cpu_tmp1_i64, cpu_env, d_offset + offsetof(XMMReg, >> > XMM_Q(1)); > It looks good (I even sent my Reviewed-by line), but: > > target

Re: [Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs

2015-01-13 Thread Eduardo Habkost
On Wed, Jan 07, 2015 at 06:39:13PM +0100, Paolo Bonzini wrote: [...] > diff --git a/target-i386/translate.c b/target-i386/translate.c > index 5af4300..253009a 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -2621,10 +2621,10 @@ static inline void gen_sto_env_A0(DisasCont

Re: [Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs

2015-01-13 Thread Eduardo Habkost
On Wed, Jan 07, 2015 at 06:39:13PM +0100, Paolo Bonzini wrote: > After the next patch, we will move the high parts of AVX and AVX512 registers > in the same array as the SSE registers. This will make it impossible to > memcpy an array of 128-bit values in and out of xmm_regs in one swoop. > Use a

[Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs

2015-01-07 Thread Paolo Bonzini
After the next patch, we will move the high parts of AVX and AVX512 registers in the same array as the SSE registers. This will make it impossible to memcpy an array of 128-bit values in and out of xmm_regs in one swoop. Use a for loop instead. Signed-off-by: Paolo Bonzini --- target-i386/kvm.c