Re: [Qemu-devel] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions

2017-11-07 Thread Stafford Horne
On Sun, Nov 05, 2017 at 03:39:48PM +0100, Laurent Vivier wrote: > Le 04/11/2017 à 22:20, Stafford Horne a écrit : > > Hello, > > > > On Fri, Nov 03, 2017 at 09:26:22PM +0100, Laurent Vivier wrote: > >> Signed-off-by: Laurent Vivier > > > > There is no commit body here, do we need one? I can see

Re: [Qemu-devel] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions

2017-11-05 Thread Laurent Vivier
Le 04/11/2017 à 22:20, Stafford Horne a écrit : > Hello, > > On Fri, Nov 03, 2017 at 09:26:22PM +0100, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier > > There is no commit body here, do we need one? I can see in your cover letter > its mentioned this was revealed after enabling "USE_SO

Re: [Qemu-devel] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions

2017-11-04 Thread Stafford Horne
Hello, On Fri, Nov 03, 2017 at 09:26:22PM +0100, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier There is no commit body here, do we need one? I can see in your cover letter its mentioned this was revealed after enabling "USE_SOFTFLOAT_STRUCT_TYPES". However, I'm just being curious why i

[Qemu-devel] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions

2017-11-03 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/openrisc/fpu_helper.c | 52 ++-- target/openrisc/helper.h | 20 - 2 files changed, 36 insertions(+), 36 deletions(-) diff --git a/target/openrisc/fpu_helper.c b/target/openrisc/fpu_helper.c index